third_party/WebKit/public/platform/WebPrivateOwnPtr.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebPrivateOwnPtr.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/public/platform/WebCommon.h ('K') | « third_party/WebKit/public/platform/WebMemoryAllocatorDump.h ('k') | third_party/WebKit/public/platform/WebPrivatePtr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebPrivateOwnPtr.h

diff --git a/third_party/WebKit/public/platform/WebPrivateOwnPtr.h b/third_party/WebKit/public/platform/WebPrivateOwnPtr.h

index 30a5cb273cf8fc2929b2fb7e16bab1a1c1c906a0..62077daea0d1853c296252704b3e110eb812e634 100644

--- a/third_party/WebKit/public/platform/WebPrivateOwnPtr.h

+++ b/third_party/WebKit/public/platform/WebPrivateOwnPtr.h

@@ -48,7 +48,7 @@ class WebPrivateOwnPtr : public WebNonCopyable {

public:

WebPrivateOwnPtr() : m_ptr(nullptr) {}

WebPrivateOwnPtr(std::nullptr_t) : m_ptr(nullptr) {}

- ~WebPrivateOwnPtr() { BLINK_ASSERT(!m_ptr); }

+ ~WebPrivateOwnPtr() { DCHECK(!m_ptr); }

explicit WebPrivateOwnPtr(T* ptr)

: m_ptr(ptr)

@@ -80,13 +80,13 @@ public:

T& operator*() const

{

- BLINK_ASSERT(m_ptr);

+ DCHECK(m_ptr);

return *m_ptr;

}

T* operator->() const

{

- BLINK_ASSERT(m_ptr);

+ DCHECK(m_ptr);

return m_ptr;

}

#endif // INSIDE_BLINK