third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 // ownership to the callee, and the proxy's lifetime is same as that of	64 // ownership to the callee, and the proxy's lifetime is same as that of

65 // WebServiceWorker.	65 // WebServiceWorker.

66 virtual void setProxy(WebServiceWorkerProxy*) { }	66 virtual void setProxy(WebServiceWorkerProxy*) { }

67 virtual WebServiceWorkerProxy* proxy() { return nullptr; }	67 virtual WebServiceWorkerProxy* proxy() { return nullptr; }

68	68

69 virtual WebURL url() const { return WebURL(); }	69 virtual WebURL url() const { return WebURL(); }

70 virtual WebServiceWorkerState state() const { return WebServiceWorkerStateUn known; }	70 virtual WebServiceWorkerState state() const { return WebServiceWorkerStateUn known; }

71	71

72 // Callee receives ownership of the passed vector.	72 // Callee receives ownership of the passed vector.

73 // FIXME: Blob refs should be passed to maintain ref counts. crbug.com/35175 3	73 // FIXME: Blob refs should be passed to maintain ref counts. crbug.com/35175 3

74 virtual void postMessage(WebServiceWorkerProvider, const WebString&, const WebSecurityOrigin&, WebMessagePortChannelArray) { BLINK_ASSERT_NOT_REACHED(); }	74 virtual void postMessage(WebServiceWorkerProvider, const WebString&, const WebSecurityOrigin&, WebMessagePortChannelArray) = 0;

75	75

76 virtual void terminate() { }	76 virtual void terminate() { }

77 };	77 };

78	78

79 }	79 }

80	80

81 #endif // WebServiceWorker_h	81 #endif // WebServiceWorker_h

OLD	NEW