Init BidiResolver with Neutral directionality in RenderText

Source/core/rendering/RenderText.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 920 matching lines @@
     float wordTrailingSpaceWidth = f.fontDescription().typesettingFeatures() & Kerning ? f.width(RenderBlockFlow::constructTextRun(this, f, &space, 1, styleToUse, textDirection)) + wordSpacing : 0;
 
     // If automatic hyphenation is allowed, we keep track of the width of the widest word (or word
     // fragment) encountered so far, and only try hyphenating words that are wider.
     float maxWordWidth = numeric_limits<float>::max();
     int firstGlyphLeftOverflow = -1;
 
     bool breakAll = (styleToUse->wordBreak() == BreakAllWordBreak || styleToUse->wordBreak() == BreakWordBreak) && styleToUse->autoWrap();
 
     TextRun textRun(text());
-    textRun.setDirection(textDirection);
     BidiResolver<TextRunIterator, BidiCharacterRun> bidiResolver;
     bidiResolver.setStatus(BidiStatus(textRun.direction(), textRun.directionalOverride()));
     bidiResolver.setPositionIgnoringNestedIsolates(TextRunIterator(&textRun, 0));
+
+    bool hasStrongDirectionality;
+    textRun.setDirection(bidiResolver.determineParagraphDirectionality(&hasStrongDirectionality));

[leviw_travelin_and_unemployed, 2014/03/01 01:37:09]

This is confusing since we're only running on a TextRun that contains the
contents of this RenderText, not the over-arching paragraph. If there's no
strong directionality, won't we default to LTR? Is that correct? I'm thinking in
the case that we haven't normalized a space between 2 RTL text nodes.

I'd like to know about that last case, and I'd recommend a comment about why
we're calling the determineParagraphDirectionality function here.

+    bidiResolver.setStatus(BidiStatus(textRun.direction(), textRun.directionalOverride()));
+    bidiResolver.setPositionIgnoringNestedIsolates(TextRunIterator(&textRun, 0));
+
     bool hardLineBreak = false;
     bool reorderRuns = false;
     bidiResolver.createBidiRunsForLine(TextRunIterator(&textRun, textRun.length()), NoVisualOverride, hardLineBreak, reorderRuns);
-
     BidiRunList<BidiCharacterRun>& bidiRuns = bidiResolver.runs();
     BidiCharacterRun* run = bidiRuns.firstRun();
     for (int i = 0; i < len; i++) {
         UChar c = uncheckedCharacterAt(i);
 
         while (i > run->stop())
             run = run->next();
 
         ASSERT(run);
         ASSERT(i >= run->start() && i <= run->stop());
@@ skipping 908 matching lines @@
     }
     secureTextTimer->restartWithNewText(lastTypedCharacterOffset);
 }
 
 PassRefPtr<AbstractInlineTextBox> RenderText::firstAbstractInlineTextBox()
 {
     return AbstractInlineTextBox::getOrCreate(this, m_firstTextBox);
 }
 
 } // namespace WebCore