Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1851203002: Add a deprecation warning for DHE. (Closed)

Created:
4 years, 8 months ago by davidben
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, estark
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a deprecation warning for DHE. Link to Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AAdv838-koo/bJv17voIBAAJ BUG=598109 TEST=Visiting https://dh1024.badssl.com/ and opening the JS console shows a deprecation warning. Committed: https://crrev.com/157660a6a5c953b387361c3890cdfa39f042d0e5 Cr-Commit-Position: refs/heads/master@{#384836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/renderer/chrome_render_frame_observer.cc View 4 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
davidben
thestig for OWNERS approval.
4 years, 8 months ago (2016-04-01 22:02:50 UTC) #3
estark
lgtm
4 years, 8 months ago (2016-04-01 23:47:57 UTC) #5
Lei Zhang
rs lgtm
4 years, 8 months ago (2016-04-02 00:00:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851203002/1
4 years, 8 months ago (2016-04-03 18:10:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-03 19:14:47 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 19:16:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/157660a6a5c953b387361c3890cdfa39f042d0e5
Cr-Commit-Position: refs/heads/master@{#384836}

Powered by Google App Engine
This is Rietveld 408576698