content/browser/web_contents/render_view_host_manager.cc - Issue 18512004: Cleanup swapped out RenderViewHosts when the process goes away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 18512004: Cleanup swapped out RenderViewHosts when the process goes away. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed whitespace Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/web_contents/render_view_host_manager_unittest.cc » ('j') | content/browser/web_contents/render_view_host_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/render_view_host_manager.cc

diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc

index ed674d5c90592252e3345ecba9780f7e0698fa3f..1148951a2cdea0982bb677ae28cab8ccb4ab6e9f 100644

--- a/content/browser/web_contents/render_view_host_manager.cc

+++ b/content/browser/web_contents/render_view_host_manager.cc

@@ -88,6 +88,8 @@ void RenderViewHostManager::Init(BrowserContext* browser_context,

site_instance)));

// Keep track of renderer processes as they start to shut down.

nasko 2013/07/10 17:29:00 nit: Update the comment to include that we track c

Fady Samuel 2013/07/10 17:51:33 Done.

+ registrar_.Add(this, NOTIFICATION_RENDERER_PROCESS_CLOSED,

+ NotificationService::AllSources());

registrar_.Add(this, NOTIFICATION_RENDERER_PROCESS_CLOSING,

NotificationService::AllSources());

}

@@ -397,6 +399,7 @@ void RenderViewHostManager::Observe(

const NotificationSource& source,

const NotificationDetails& details) {

switch (type) {

+ case NOTIFICATION_RENDERER_PROCESS_CLOSED:

case NOTIFICATION_RENDERER_PROCESS_CLOSING:

RendererProcessClosing(

Source<RenderProcessHost>(source).ptr());