Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1851123002: SkPDF: PDFShader does not hold images/bitmaps (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: PDFShader does not hold images/bitmaps motivation: measurable memory savings. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851123002 Committed: https://skia.googlesource.com/skia/+/389666bf1fed53a92b8c320157ee5fc0d5173552

Patch Set 1 : 2016-04-01 (Friday) 13:59:49 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/pdf/SkPDFShader.cpp View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851123002/20001
4 years, 8 months ago (2016-04-01 18:00:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 18:11:38 UTC) #7
hal.canary
PTAL
4 years, 8 months ago (2016-04-01 18:13:19 UTC) #9
tomhudson
lgtm
4 years, 8 months ago (2016-04-01 18:41:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851123002/20001
4 years, 8 months ago (2016-04-01 18:42:44 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:43:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/389666bf1fed53a92b8c320157ee5fc0d5173552

Powered by Google App Engine
This is Rietveld 408576698