Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1851113003: Add bash shell function to make python work like it should. (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
Reviewers:
dnj
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add bash shell function to make python work like it should. This uses the virtual /proc filesystem to identify when the user runs `python` without redirecting stdout/stdin. If this is the case, we run `python -i` instead. Otherwise, or if there are arguments, we run it verbatim. R=dnj@chromium.org BUG=598956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299681

Patch Set 1 #

Patch Set 2 : actually look for python.sh #

Patch Set 3 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A bootstrap/win/profile.d.python.sh View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M bootstrap/win/win_tools.bat View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
iannucci
4 years, 8 months ago (2016-04-02 07:05:25 UTC) #1
iannucci
PTAL. This is needed because our CPython's 'isatty' function is broken under the msys shell. ...
4 years, 8 months ago (2016-04-02 07:07:54 UTC) #2
iannucci
On 2016/04/02 at 07:07:54, iannucci wrote: > PTAL. This is needed because our CPython's 'isatty' ...
4 years, 8 months ago (2016-04-03 00:20:15 UTC) #3
dnj
lgtm, can you add a quick comment to the top of this file explaining why ...
4 years, 8 months ago (2016-04-03 00:59:35 UTC) #4
iannucci
Committed patchset #3 (id:40001) manually as 299681.
4 years, 8 months ago (2016-04-04 21:22:46 UTC) #6
iannucci
4 years, 8 months ago (2016-04-04 21:23:08 UTC) #7
Message was sent while issue was closed.
(add comment: done)

Powered by Google App Engine
This is Rietveld 408576698