Trace events corresponding to GCTracer scopes.

Trace events corresponding to GCTracer scopes.

BUG=chromium:597310
LOG=NO

Committed: https://crrev.com/2b9c99a861db72ab280b0d08d3b745b2140edc8e
Cr-Commit-Position: refs/heads/master@{#35233}

[ulan, 2016-04-01 16:11:43]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-04-01 16:11:43]

PTAL. Now each GCTracer scope also creates events visible in chrome://tracing.

[Michael Lippautz, 2016-04-04 09:49:39]

lgtm

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:48: #define CASE(scope)  \
undef CASE somewhere?

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.h#ne...
src/heap/gc-tracer.h:129: NUMBER_OF_SCOPES
nit: Indentation? (maybe it's a formatter issue)

[ulan, 2016-04-04 09:58:42]

Thanks

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:48: #define CASE(scope)  \
On 2016/04/04 at 09:49:39, Michael Lippautz wrote:
> undef CASE somewhere?

Done.

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):

https://codereview.chromium.org/1851103002/diff/40001/src/heap/gc-tracer.h#ne...
src/heap/gc-tracer.h:129: NUMBER_OF_SCOPES
On 2016/04/04 at 09:49:39, Michael Lippautz wrote:
> nit: Indentation? (maybe it's a formatter issue)

It's a formatter issue.

[ulan, 2016-04-04 10:02:00]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-04-04 10:02:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1851103002/#ps60001
(title: "Address comment")

[commit-bot: I haz the power, 2016-04-04 10:02:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851103002/60001

[commit-bot: I haz the power, 2016-04-04 10:41:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-04 10:42:46]

Description was changed from

==========
Trace events corresponding to GCTracer scopes.

BUG=chromium:597310
LOG=NO
==========

to

==========
Trace events corresponding to GCTracer scopes.

BUG=chromium:597310
LOG=NO

Committed: https://crrev.com/2b9c99a861db72ab280b0d08d3b745b2140edc8e
Cr-Commit-Position: refs/heads/master@{#35233}
==========

[commit-bot: I haz the power, 2016-04-04 10:42:47]

Patchset 4 (id:??) landed as
https://crrev.com/2b9c99a861db72ab280b0d08d3b745b2140edc8e
Cr-Commit-Position: refs/heads/master@{#35233}

[Michael Achenbach, 2016-04-04 12:19:41]

This crash happened after this CL:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/4264

Could you investigate if this is the cause or if there's another patch before
that triggers it?

[Michael Achenbach, 2016-04-04 12:20:19]

On 2016/04/04 12:19:41, Michael Achenbach (OOO) wrote:
> This crash happened after this CL:
> https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/4264
> 
> Could you investigate if this is the cause or if there's another patch before
> that triggers it?

FYI: Stack:
STDERR: 	v8::internal::NamedLoadHandlerCompiler::ComputeLoadNonexistent
[0x033AA783+147]
STDERR: 	v8::internal::LoadIC::UpdateCaches [0x033B929E+126]
STDERR: 	v8::internal::LoadIC::Load [0x033B06F5+805]
STDERR: 	v8::internal::Runtime_LoadIC_Miss [0x033B437A+1194]

[ulan, 2016-04-04 12:26:26]

On 2016/04/04 at 12:20:19, machenbach wrote:
> On 2016/04/04 12:19:41, Michael Achenbach (OOO) wrote:
> > This crash happened after this CL:
> >
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/4264
> > 
> > Could you investigate if this is the cause or if there's another patch
before
> > that triggers it?
> 
> FYI: Stack:
> STDERR: 	v8::internal::NamedLoadHandlerCompiler::ComputeLoadNonexistent
[0x033AA783+147]
> STDERR: 	v8::internal::LoadIC::UpdateCaches [0x033B929E+126]
> STDERR: 	v8::internal::LoadIC::Load [0x033B06F5+805]
> STDERR: 	v8::internal::Runtime_LoadIC_Miss [0x033B437A+1194]

The change in CL is disabled by default, so the CL shouldn't change behavior.
Also the stack trace looks unrelated.