Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1851093003: Revert of Change net's predictor_tab_helper to use the new content Navigation API (Closed)

Created:
4 years, 8 months ago by Charlie Harrison
Modified:
4 years, 8 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change net's predictor_tab_helper to use the new content Navigation API (patchset #6 id:100001 of https://codereview.chromium.org/1813553004/ ) Reason for revert: This caused regressions in Android page_cycler perf bots of ~150-200ms. See crbug.com/599502. Original issue's description: > Change net's predictor_tab_helper to use the new content Navigation API > > This change moves the trigger for preconnects/preresolves from > DidStartNavigationToPendingEntry to DidStartNavigation, broadening the > navigations that we can predict from. > > BUG=595730 > > Committed: https://crrev.com/778dddc6edcfbc8e420e0ed019acf506b7bdd864 > Cr-Commit-Position: refs/heads/master@{#383714} TBR=asvitkine@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595730 Committed: https://crrev.com/57e4eb88b6db415149784a75f600623e21f325b3 Cr-Commit-Position: refs/heads/master@{#384600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -121 lines) Patch
M chrome/browser/net/predictor_tab_helper.h View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/net/predictor_tab_helper.cc View 2 chunks +4 lines, -32 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -20 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -20 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -20 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Charlie Harrison
Created Revert of Change net's predictor_tab_helper to use the new content Navigation API
4 years, 8 months ago (2016-04-01 15:28:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851093003/1
4 years, 8 months ago (2016-04-01 15:28:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851093003/1
4 years, 8 months ago (2016-04-01 15:31:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851093003/1
4 years, 8 months ago (2016-04-01 16:01:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 16:20:53 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 16:21:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57e4eb88b6db415149784a75f600623e21f325b3
Cr-Commit-Position: refs/heads/master@{#384600}

Powered by Google App Engine
This is Rietveld 408576698