ios/web/web_state/ui/crw_wk_web_view_web_controller.mm - Issue 1851003003: [ios] Added web// public API to let embedder observe loading progress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

Issue 1851003003: [ios] Added web// public API to let embedder observe loading progress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/web/public/web_state/web_state_delegate.h ('K') | « ios/web/shell/view_controller.mm ('k') | ios/web/web_state/web_state_delegate.mm » ('j') | ios/web/web_state/web_state_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

index ece3a51c7f1c7ba0c2303f93748c42398bdcfc46..4cdbb00bd7c4ab859898f925eb8471b7d7d99d9e 100644

--- a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

+++ b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

@@ -1187,6 +1187,10 @@ NSError* WKWebViewErrorWithSource(NSError* error, WKWebViewErrorSource source) {

}

- (void)webViewEstimatedProgressDidChange {

+ if ([self isBeingDestroyed])

+ return;

+ self.webStateImpl->SendChangeLoadProgress([_wkWebView estimatedProgress]);

if ([self.delegate respondsToSelector:

@selector(webController:didUpdateProgress:)]) {

[self.delegate webController:self

« ios/web/public/web_state/web_state_delegate.h ('K') | « ios/web/shell/view_controller.mm ('k') | ios/web/web_state/web_state_delegate.mm » ('j') | ios/web/web_state/web_state_impl.h » ('J')