[ios] Added web// public API to let embedder observe loading progress.

[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver

In content// loading progress is reported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc: https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWbAA/edit#
BUG=597997
Committed: https://crrev.com/9dbebc8ed2f1c636167d7e39b88c589024eaf069
Cr-Commit-Position: refs/heads/master@{#387936}

[Eugene But (OOO till 7-30), 2016-04-02 04:03:37]

Description was changed from

==========
[ios] Added web/ public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver


In content// loading progress is rrported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

BUG=597997
==========

to

==========
[ios] Added web/ public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver


In content// loading progress is rrported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

[Eugene But (OOO till 7-30), 2016-04-02 04:03:50]

Description was changed from

==========
[ios] Added web/ public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver


In content// loading progress is rrported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

to

==========
[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver


In content// loading progress is rrported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

[Eugene But (OOO till 7-30), 2016-04-02 04:04:42]

Description was changed from

==========
[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver


In content// loading progress is rrported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

to

==========
[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver

In content// loading progress is reported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

[Eugene But (OOO till 7-30), 2016-04-02 04:07:42]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 04:07:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003003/1

[commit-bot: I haz the power, 2016-04-02 04:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 04:39:08]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-04-06 21:35:15]

eugenebut@chromium.org changed reviewers:
+ marq@chromium.org, rohitrao@chromium.org

[Eugene But (OOO till 7-30), 2016-04-06 21:35:17]

https://codereview.chromium.org/1851003003/diff/1/ios/web/shell/view_controll...
File ios/web/shell/view_controller.mm (right):

https://codereview.chromium.org/1851003003/diff/1/ios/web/shell/view_controll...
ios/web/shell/view_controller.mm:34: @interface ViewController
()<CRWWebStateDelegate, CRWWebStateObserver> {
This is unused now, but works as example and a basis for the future changes.

[Eugene But (OOO till 7-30), 2016-04-09 04:23:07]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-09 04:23:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003003/40001

[commit-bot: I haz the power, 2016-04-09 05:08:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-09 05:08:24]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-04-13 12:01:13]

How did this method end up in WebContentsDelegate instead of
WebContentsObserver?  We should match this so that we mirror //content, but this
doesn't really feel like a delegate method at all.

Do you know which classes are WebContentsDelegates on desktop?  Who will be the
delegate on iOS in the magical future when Tab is gone?

https://codereview.chromium.org/1851003003/diff/40001/ios/web/public/web_stat...
File ios/web/public/web_state/web_state_delegate.h (right):

https://codereview.chromium.org/1851003003/diff/40001/ios/web/public/web_stat...
ios/web/public/web_state/web_state_delegate.h:44: // The WebStates for which
|this| is currently a delegate for.
Omit the second "for".

https://codereview.chromium.org/1851003003/diff/40001/ios/web/web_state/web_s...
File ios/web/web_state/web_state_impl.h (right):

https://codereview.chromium.org/1851003003/diff/40001/ios/web/web_state/web_s...
ios/web/web_state/web_state_impl.h:275: // Unowned delegate.
We generally use "weak" instead of "unowned".

[Eugene But (OOO till 7-30), 2016-04-13 15:03:53]

>> How did this method end up in WebContentsDelegate instead of
WebContentsObserver?
I guess in the same way as:
 - NavigationStateChanged
 - VisibleSSLStateChanged
 - LoadingStateChanged
 - ContentsZoomChange
 - WillRunBeforeUnloadConfirm
 - BeforeUnloadFired
 - RendererUnresponsive
 - RendererResponsive
 - DidNavigateMainFramePostCommit

...historical reasons. I can ask content// folks this question, but I don't
think that their answer will help us. WebContentsDelegate has so many things
that is better fit for WebContentsObserver, but it is what it is, and I think we
should mirror their API. WDYT?

https://codereview.chromium.org/1851003003/diff/40001/ios/web/public/web_stat...
File ios/web/public/web_state/web_state_delegate.h (right):

https://codereview.chromium.org/1851003003/diff/40001/ios/web/public/web_stat...
ios/web/public/web_state/web_state_delegate.h:44: // The WebStates for which
|this| is currently a delegate for.
On 2016/04/13 12:01:13, rohitrao wrote:
> Omit the second "for".

Done.

https://codereview.chromium.org/1851003003/diff/40001/ios/web/web_state/web_s...
File ios/web/web_state/web_state_impl.h (right):

https://codereview.chromium.org/1851003003/diff/40001/ios/web/web_state/web_s...
ios/web/web_state/web_state_impl.h:275: // Unowned delegate.
On 2016/04/13 12:01:13, rohitrao wrote:
> We generally use "weak" instead of "unowned".
Agree that Bling generally use "weak". But "weak" means something specific in
Objective-C world, a reference which is either valid or null and never dangles.
Because of that I don't want to use the same name for different things.  Updated
the comment, since no one lines "Unowned" word: "Delegate, not owned by this
object."

[rohitrao (ping after 24h), 2016-04-18 11:30:48]

LGTM

> >> How did this method end up in WebContentsDelegate instead of
> WebContentsObserver?
> ...historical reasons. I can ask content// folks this question, but I don't
> think that their answer will help us. WebContentsDelegate has so many things
> that is better fit for WebContentsObserver, but it is what it is, and I think
we
> should mirror their API. WDYT?

Yeah, we should mirror the //content API everywhere we can.

[Eugene But (OOO till 7-30), 2016-04-18 14:10:57]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-04-18 14:11:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003003/60001

[commit-bot: I haz the power, 2016-04-18 14:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 14:13:44]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eugene But (OOO till 7-30), 2016-04-18 16:22:43]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-04-18 16:22:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/1851003003/#ps140001
(title: "Fixed compilation")

[commit-bot: I haz the power, 2016-04-18 16:22:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003003/140001

[commit-bot: I haz the power, 2016-04-18 17:24:40]

Description was changed from

==========
[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver

In content// loading progress is reported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

to

==========
[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver

In content// loading progress is reported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

[commit-bot: I haz the power, 2016-04-18 17:24:41]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-18 17:26:41]

Description was changed from

==========
[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver

In content// loading progress is reported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997
==========

to

==========
[ios] Added web// public API to let embedder observe loading progress.

All web// API follows the approach of content// API:
WebClient is analogue of ContentBrowserClient
NavigationManager is analogue of NavigationController
WebState is for WebContents
WebStateObserver is for WebContentsObserver

In content// loading progress is reported via
WebContentsDelegate::LoadProgressChanged. In web// progress will be
reported via WebStateDelegate::LoadProgressChanged and
WebStateDelegateBridge to allow Objective-C clients use this API.

WebStateDelegate will also be used to support context menus and JS
dialogs in the future.

doc:
https://docs.google.com/document/d/1QnO4GTeFDm7W6cK0boELl2DxSXsd90TXEUsCBBmWb...
BUG=597997

Committed: https://crrev.com/9dbebc8ed2f1c636167d7e39b88c589024eaf069
Cr-Commit-Position: refs/heads/master@{#387936}
==========

[commit-bot: I haz the power, 2016-04-18 17:26:42]

Patchset 8 (id:??) landed as
https://crrev.com/9dbebc8ed2f1c636167d7e39b88c589024eaf069
Cr-Commit-Position: refs/heads/master@{#387936}