Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp

Issue 1851003002: Throw TypeError if easing string is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
diff --git a/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp b/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
index 55f811107c4b679502d647b3629b9eeacd35a519..a7b9992a06d798b95451b95a2c6d0208d4e990ea 100644
--- a/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
+++ b/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
@@ -4,6 +4,7 @@
#include "core/animation/AnimationEffectTiming.h"
+#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/UnionTypesCore.h"
#include "core/animation/AnimationEffect.h"
#include "core/animation/KeyframeEffect.h"
@@ -127,11 +128,11 @@ void AnimationEffectTiming::setDirection(String direction)
m_parent->updateSpecifiedTiming(timing);
}
-void AnimationEffectTiming::setEasing(String easing)
+void AnimationEffectTiming::setEasing(String easing, ExceptionState& exceptionState)
{
Timing timing = m_parent->specifiedTiming();
- TimingInput::setTimingFunction(timing, easing);
- m_parent->updateSpecifiedTiming(timing);
+ if (TimingInput::setTimingFunction(timing, easing, exceptionState))
+ m_parent->updateSpecifiedTiming(timing);
}
DEFINE_TRACE(AnimationEffectTiming)

Powered by Google App Engine
This is Rietveld 408576698