Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/core/animation/TimingInput.h

Issue 1851003002: Throw TypeError if easing string is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use DCHECK instead of ASSERT; fix animation-effect-timing-easing layout test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/TimingInput.h
diff --git a/third_party/WebKit/Source/core/animation/TimingInput.h b/third_party/WebKit/Source/core/animation/TimingInput.h
index 073f180d3094aabcd0284d4b4b613f9e6434848f..fc7253f78f9409087c0da157f9ed5bcbcf966a67 100644
--- a/third_party/WebKit/Source/core/animation/TimingInput.h
+++ b/third_party/WebKit/Source/core/animation/TimingInput.h
@@ -13,13 +13,14 @@ namespace blink {
class Dictionary;
class Document;
+class ExceptionState;
class KeyframeEffectOptions;
class CORE_EXPORT TimingInput {
STATIC_ONLY(TimingInput);
public:
- static Timing convert(const KeyframeEffectOptions& timingInput, Document*);
- static Timing convert(double duration);
+ static bool convert(const KeyframeEffectOptions& timingInput, Timing& timingOutput, Document*, ExceptionState&);
+ static bool convert(double duration, Timing& timingOutput);
static void setStartDelay(Timing&, double startDelay);
static void setEndDelay(Timing&, double endDelay);
@@ -29,7 +30,7 @@ public:
static void setIterationDuration(Timing&, double iterationDuration);
static void setPlaybackRate(Timing&, double playbackRate);
static void setPlaybackDirection(Timing&, const String& direction);
- static void setTimingFunction(Timing&, const String& timingFunctionString, Document*);
+ static bool setTimingFunction(Timing&, const String& timingFunctionString, Document*, ExceptionState&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698