trunk/Source/modules/speech/SpeechSynthesis.cpp - Issue 185093002: Revert 168169 "Fix use-after-free of m_currentSpeechUtterance."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/modules/speech/SpeechSynthesis.cpp

Issue 185093002: Revert 168169 "Fix use-after-free of m_currentSpeechUtterance." (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/Source/modules/speech/SpeechSynthesis.cpp

===================================================================

--- trunk/Source/modules/speech/SpeechSynthesis.cpp (revision 168169)

+++ trunk/Source/modules/speech/SpeechSynthesis.cpp (working copy)

@@ -222,13 +222,6 @@

handleSpeakingCompleted(static_cast<SpeechSynthesisUtterance*>(utterance->client()), true);

}

-SpeechSynthesisUtterance* SpeechSynthesis::currentSpeechUtterance() const

- if (!m_utteranceQueue.isEmpty())

- return m_utteranceQueue.first().get();

- return 0;

const AtomicString& SpeechSynthesis::interfaceName() const

{

return EventTargetNames::SpeechSynthesisUtterance;

« no previous file with comments | « no previous file | no next file » | no next file with comments »