Disable the autofill password manager when a credential is sent via CM API.

Disable the autofill password manager when a credential is sent via CM API.

BUG=599836
Committed: https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf
Cr-Commit-Position: refs/heads/master@{#385164}

[vasilii, 2016-04-05 01:23:54]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-04-05 01:23:55]

Hi Vaclav,

please review.

[vabr (Chromium), 2016-04-05 11:46:51]

LGTM, thanks for the fix!

Vaclav

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/credential_manager_browsertest.cc (right):

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
chrome/browser/password_manager/credential_manager_browsertest.cc:30:
DISALLOW_COPY_AND_ASSIGN(CredentialManagerBrowserTest);
#include "base/macros.h" for this?

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
chrome/browser/password_manager/credential_manager_browsertest.cc:37: // Save
credentials with 'skip_zero_click'
nit: Insert a full-stop (.) at the end of the sentence.

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
chrome/browser/password_manager/credential_manager_browsertest.cc:60:
".then(cred => window.location = '/password/done.html')"));
[non-blocking comment]: I have to ask about this syntax in person. It blows my
mind! :)

[vasilii, 2016-04-05 12:51:55]

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/credential_manager_browsertest.cc (right):

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
chrome/browser/password_manager/credential_manager_browsertest.cc:30:
DISALLOW_COPY_AND_ASSIGN(CredentialManagerBrowserTest);
On 2016/04/05 11:46:51, vabr (Chromium) wrote:
> #include "base/macros.h" for this?

Done.

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
chrome/browser/password_manager/credential_manager_browsertest.cc:37: // Save
credentials with 'skip_zero_click'
On 2016/04/05 11:46:51, vabr (Chromium) wrote:
> nit: Insert a full-stop (.) at the end of the sentence.

Done.

https://codereview.chromium.org/1850923004/diff/20001/chrome/browser/password...
chrome/browser/password_manager/credential_manager_browsertest.cc:60:
".then(cred => window.location = '/password/done.html')"));
On 2016/04/05 11:46:50, vabr (Chromium) wrote:
> [non-blocking comment]: I have to ask about this syntax in person. It blows my
> mind! :)

Done.

[vasilii, 2016-04-05 12:52:00]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-04-05 12:52:00]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1850923004/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2016-04-05 12:52:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850923004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850923004/40001

[commit-bot: I haz the power, 2016-04-05 14:04:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 14:05:34]

Description was changed from

==========
Disable the autofill password manager when a credential is sent via CM API.

BUG=599836
==========

to

==========
Disable the autofill password manager when a credential is sent via CM API.

BUG=599836

Committed: https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf
Cr-Commit-Position: refs/heads/master@{#385164}
==========

[commit-bot: I haz the power, 2016-04-05 14:05:35]

Patchset 3 (id:??) landed as
https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf
Cr-Commit-Position: refs/heads/master@{#385164}