Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1850903002: Enable user gesture requirement for autoplay experiment. (Closed)

Created:
4 years, 8 months ago by liberato (no reviews please)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable user gesture requirement for autoplay experiment. For android, the autoplay experiment operated independently of the user gesture requirement for media elements. To deploy the experiment on desktop, the experiment has to enable the user gesture requirement, else there won't be much for it to do. BUG=599679 Committed: https://crrev.com/9e93489f36f1d34cb0eb0ae828e78d9a84ae8b95 Cr-Commit-Position: refs/heads/master@{#391318}

Patch Set 1 #

Total comments: 6

Patch Set 2 : cl feedback. #

Patch Set 3 : rebased. #

Patch Set 4 : rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 24 (9 generated)
liberato (no reviews please)
very small change to the autoplay experiment to let us try out stuff on desktop. ...
4 years, 8 months ago (2016-04-04 16:11:05 UTC) #3
philipj_slow
https://codereview.chromium.org/1850903002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1850903002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode432 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:432: // default, else the experiment does nothing. s/else/otherwise/ https://codereview.chromium.org/1850903002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode433 ...
4 years, 8 months ago (2016-04-05 11:17:52 UTC) #4
mlamouri (slow - plz ping)
Should we clean up the experiements currently in AutoplayExperimentHelper.h? https://codereview.chromium.org/1850903002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1850903002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode433 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:433: ...
4 years, 8 months ago (2016-04-21 17:11:36 UTC) #6
liberato (no reviews please)
https://codereview.chromium.org/1850903002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1850903002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode432 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:432: // default, else the experiment does nothing. On 2016/04/05 ...
4 years, 8 months ago (2016-04-25 22:38:44 UTC) #7
mlamouri (slow - plz ping)
lgtm
4 years, 8 months ago (2016-04-26 14:48:40 UTC) #8
mlamouri (slow - plz ping)
Note: I only own the Blink files. You will have to get another reviewer for ...
4 years, 8 months ago (2016-04-26 14:49:21 UTC) #9
liberato (no reviews please)
brettw: PTAL @content/ mounir: thanks for the discussion! thanks -fl
4 years, 8 months ago (2016-04-26 15:30:59 UTC) #11
mlamouri (slow - plz ping)
+jochen@ (also content/ owner)
4 years, 7 months ago (2016-05-02 13:51:18 UTC) #12
mlamouri (slow - plz ping)
4 years, 7 months ago (2016-05-02 13:51:26 UTC) #14
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-02 16:07:04 UTC) #15
liberato (no reviews please)
brettw: PTAL @ content/ for owners approval jochen, mlamouri: thanks thanks -fl
4 years, 7 months ago (2016-05-03 16:27:22 UTC) #16
liberato (no reviews please)
brettw: never mind, thanks!
4 years, 7 months ago (2016-05-03 16:48:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850903002/60001
4 years, 7 months ago (2016-05-03 16:48:26 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-03 19:00:37 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 19:02:47 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9e93489f36f1d34cb0eb0ae828e78d9a84ae8b95
Cr-Commit-Position: refs/heads/master@{#391318}

Powered by Google App Engine
This is Rietveld 408576698