Avoid persisting of QUIC server config information in Stable and Beta

Avoid persisting of QUIC server config information in Stable and Beta
channels.

Will delete this flag once we have implemented clearing of QUIC
server config information from clearing cookies dialog.

r=rch, eroman, sky, jar

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254562

[ramant (doing other things), 2014-02-28 23:42:59]

eroman: net_internals
sky: chrome/io_thread*

Server config information is cleared whenever disk cache is cleared. 

Will hook up clearing of disk cache and memory cache from cookie's dialog (ala
CHANNEL_ID's clearing from clear cookies dialog boxes) real soon. Will delete
this code after that is implemented.

This is the temporary solution jar, rch and I had come up.

Please take a look.

Thanks
raman

[sky, 2014-03-01 00:06:53]

LGTM

[Ryan Hamilton, 2014-03-01 00:38:27]

lgtm, just a couple nits

https://codereview.chromium.org/185083002/diff/20001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/185083002/diff/20001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:429: 
I don't think I would add these flags.  I don't think we'll really make use of
them.

https://codereview.chromium.org/185083002/diff/20001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:432: const char kDisableQuicPortSelection[]    
 = "disable-quic-port-selection";
hah!  nice catch!

https://codereview.chromium.org/185083002/diff/20001/net/http/http_cache.cc
File net/http/http_cache.cc (right):

https://codereview.chromium.org/185083002/diff/20001/net/http/http_cache.cc#n...
net/http/http_cache.cc:295: quic_server_info_factory_.reset(new
QuicServerInfoFactoryAdaptor(this));
nit: if you wanted to make quic_server_info_factory_ const, I think you could
still do that by using the ?: operator in the initializer list:

quic_server_info_factory_(
  params.enable_quic_persist_server_info ? 
    new QuicServerInfoFactoryAdaptor(this)) :
    NULL);

(or some such... or you could extract this logic to a function)

[ramant (doing other things), 2014-03-01 01:22:22]

Made the changes rch has suggested. PTAL.

https://codereview.chromium.org/185083002/diff/20001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/185083002/diff/20001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:429: 
On 2014/03/01 00:38:27, Ryan Hamilton wrote:
> I don't think I would add these flags.  I don't think we'll really make use of
> them.

Done.

https://codereview.chromium.org/185083002/diff/20001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:432: const char kDisableQuicPortSelection[]    
 = "disable-quic-port-selection";
On 2014/03/01 00:38:27, Ryan Hamilton wrote:
> hah!  nice catch!

Thanks much.

https://codereview.chromium.org/185083002/diff/20001/net/http/http_cache.cc
File net/http/http_cache.cc (right):

https://codereview.chromium.org/185083002/diff/20001/net/http/http_cache.cc#n...
net/http/http_cache.cc:295: quic_server_info_factory_.reset(new
QuicServerInfoFactoryAdaptor(this));
On 2014/03/01 00:38:27, Ryan Hamilton wrote:
> nit: if you wanted to make quic_server_info_factory_ const, I think you could
> still do that by using the ?: operator in the initializer list:
> 
> quic_server_info_factory_(
>   params.enable_quic_persist_server_info ? 
>     new QuicServerInfoFactoryAdaptor(this)) :
>     NULL);
> 
> (or some such... or you could extract this logic to a function)

Done.

[Ryan Hamilton, 2014-03-01 04:21:23]

lgtm

[mmenke, 2014-03-03 16:38:53]

On 2014/03/01 04:21:23, Ryan Hamilton wrote:
> lgtm

net_internals LGTM.

[ramant (doing other things), 2014-03-03 16:44:23]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-03-03 16:44:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/185083002/40001

[commit-bot: I haz the power, 2014-03-03 17:33:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/185083002/40001

[commit-bot: I haz the power, 2014-03-03 18:23:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/185083002/40001

[commit-bot: I haz the power, 2014-03-03 19:53:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/185083002/40001

[commit-bot: I haz the power, 2014-03-03 21:13:22]

Change committed as 254562