media/base/media_log.h - Issue 1850733003: Media: Report informational error messages to HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/media_log.h

Issue 1850733003: Media: Report informational error messages to HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use_locking_in_rendermedialog

Patch Set: Rebase to ToT, address watk@'s nits. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/media_log.h

diff --git a/media/base/media_log.h b/media/base/media_log.h

index d927883cd01d66ac30e1bb331c87e6c4194455a1..6ab18597eac7c45d010b261dd2e9125f2d733764 100644

--- a/media/base/media_log.h

+++ b/media/base/media_log.h

@@ -44,6 +44,9 @@ class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {

// with it.

virtual void AddEvent(scoped_ptr<MediaLogEvent> event);

+ // Retrieve an error message, if any.

+ virtual std::string GetLastErrorMessage();

// Helper methods to create events and their parameters.

scoped_ptr<MediaLogEvent> CreateEvent(MediaLogEvent::Type type);

scoped_ptr<MediaLogEvent> CreateBooleanEvent(

« no previous file with comments | « content/renderer/media/webmediaplayer_ms.cc ('k') | media/base/media_log.cc » ('j') | no next file with comments »