content/renderer/media/android/webmediaplayer_android.cc - Issue 1850733003: Media: Report informational error messages to HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 1850733003: Media: Report informational error messages to HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use_locking_in_rendermedialog

Patch Set: Rebase to ToT, address watk@'s nits. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.h ('k') | content/renderer/media/html_video_element_capturer_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/webmediaplayer_android.cc

diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc

index ef9ddf1049ce92626fb47ace797fe210b803598d..17caed4e0a3da3a88a86a1a603b492878dfb5206 100644

--- a/content/renderer/media/android/webmediaplayer_android.cc

+++ b/content/renderer/media/android/webmediaplayer_android.cc

@@ -619,6 +619,10 @@ WebMediaPlayer::ReadyState WebMediaPlayerAndroid::getReadyState() const {

return ready_state_;

}

+blink::WebString WebMediaPlayerAndroid::getErrorMessage() {

+ return blink::WebString::fromUTF8(media_log_->GetLastErrorMessage());

blink::WebTimeRanges WebMediaPlayerAndroid::buffered() const {

if (media_source_delegate_)

return media_source_delegate_->Buffered();