Issue 1850703004: [Discardable Shared Memory] Remove Windows (un)pinning support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1850703004: [Discardable Shared Memory] Remove Windows (un)pinning support. (Closed)

Created:
4 years, 8 months ago by pennymac

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[Discardable Shared Memory] Remove Windows (un)pinning support. Removing MEM_RESET and MEM_RESET_UNDO from Unlock and Lock functions. The overhead is a bit too high for some scenarios. See ticket 595930 for details and plans for potential future implementations. BUG=180334, 595930 Review URL: https://codereview.chromium.org/1832183002 Cr-Commit-Position: refs/heads/master@{#383514} (cherry picked from commit 6a2afca1819c6f14aff51dd94aead834e6ad6fd8) Committed: https://chromium.googlesource.com/chromium/src/+/2b1af3bda9c60987393ece94c49f86c98df4a666

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -24 lines)			Patch
	M	base/memory/discardable_shared_memory.cc	View		3 chunks	+0 lines, -24 lines	0 comments	Download

Total messages: 2 (1 generated)

pennymac

4 years, 8 months ago (2016-03-31 18:22:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2b1af3bda9c60987393ece94c49f86c98df4a666.