Issue 18507: More scaffolding for back/forward, start of WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18507: More scaffolding for back/forward, start of WebContents (Closed)

Created:
11 years, 11 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

More scaffolding for back/forward/reload/home, start of WebContents Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8493

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -14 lines)			Patch
M	chrome/browser/browser.h	View	1	7 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1	14 chunks	+19 lines, -4 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	1	3 chunks	+77 lines, -4 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cpp	View	1	1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 11 months ago (2009-01-22 18:31:07 UTC) #2

LGTM

http://codereview.chromium.org/18507/diff/12/207
File chrome/common/temp_scaffolding_stubs.cpp (right):

http://codereview.chromium.org/18507/diff/12/207#newcode225
Line 225: return GURL("http://www.chromium.org");
dev.chromium.org! ;D

Expand Messages | Collapse Messages