Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1850693005: Fix a munged Shift-JIS layout test file (Closed)

Created:
4 years, 8 months ago by jungshik at Google
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a munged Shift-JIS layout test file fast/encoding/invalid-multi-byte-over-consumption.html is supposed to have a sequence of '0x83 0x22' (an invalid sequence in Shift_JIS), but it's somehow changed to '0xEF 0xBF 0xBD' (UTF-8 representation of U+FFFD - replacement characters) followed by 0x22. The whole point of this test is to make sure that only the first byte (0x83) of a 'two-byte invalid sequence' is consumed and the second byte (0x22) is interpreted as U+0022. So, having '0xEF 0xBF 0xBD' defeats the purpose of this test. Note that this file has to be landed manually because rietveld cannot handle a non-UTF-8 text file. BUG=597517 TEST=the above layout test. TBR=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b03c4cbfe2ae0a323ea5c4c5ce56d1e336f095cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/encoding/invalid-multi-byte-over-consumption.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jungshik at Google
Sorry to bother you. Review is not possible in riedvelt because it involves a non-UTF-8 ...
4 years, 8 months ago (2016-04-01 09:29:24 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b03c4cbfe2ae0a323ea5c4c5ce56d1e336f095cf Cr-Commit-Position: refs/heads/master@{#384531}
4 years, 8 months ago (2016-04-01 09:33:22 UTC) #3
jungshik at Google
Committed patchset #1 (id:1) manually as b03c4cbfe2ae0a323ea5c4c5ce56d1e336f095cf (presubmit successful).
4 years, 8 months ago (2016-04-01 09:34:05 UTC) #5
Dirk Pranke
4 years, 8 months ago (2016-04-01 16:59:02 UTC) #6
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698