Chromium Code Reviews
DescriptionFix a munged Shift-JIS layout test file
fast/encoding/invalid-multi-byte-over-consumption.html is supposed to
have a sequence of '0x83 0x22' (an invalid sequence in Shift_JIS), but
it's somehow changed to '0xEF 0xBF 0xBD' (UTF-8 representation of
U+FFFD - replacement characters) followed by 0x22.
The whole point of this test is to make sure that only the first byte (0x83)
of a 'two-byte invalid sequence' is consumed and the second byte (0x22) is
interpreted as U+0022. So, having '0xEF 0xBF 0xBD' defeats the purpose of
this test.
Note that this file has to be landed manually because rietveld cannot
handle a non-UTF-8 text file.
BUG=597517
TEST=the above layout test.
TBR=dpranke@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/b03c4cbfe2ae0a323ea5c4c5ce56d1e336f095cf
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||