Android NTP: only query TopSites if SuggestionsService has nothing in the cache

Android NTP: only query TopSites if SuggestionsService has nothing in the cache

BUG=596857
Committed: https://crrev.com/ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d
Cr-Commit-Position: refs/heads/master@{#384260}

[Marc Treib, 2016-03-31 12:22:32]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 12:22:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850673002/1

[Marc Treib, 2016-03-31 12:26:03]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-03-31 12:26:03]

PTAL!

https://codereview.chromium.org/1850673002/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/most_visited_sites.cc (left):

https://codereview.chromium.org/1850673002/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/most_visited_sites.cc:421: if
(!suggestions_service->FetchSuggestionsData())
What happened before is:
This got called from SetMostVisitedURLsObserver above, after we had fetched the
cached suggestions.
suggestions_service->FetchSuggestionsData would return false ("No, I didn't send
a network request, because I don't know yet if History Sync is enabled"), so
we'd fall back to TopSites, which would overwrite our cached suggestions.

[commit-bot: I haz the power, 2016-03-31 13:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 13:08:08]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-03-31 13:16:32]

lgtm

[Marc Treib, 2016-03-31 13:21:32]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-03-31 13:21:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850673002/1

[commit-bot: I haz the power, 2016-03-31 13:26:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-31 13:27:49]

Description was changed from

==========
Android NTP: only query TopSites if SuggestionsService has nothing in the cache

BUG=596857
==========

to

==========
Android NTP: only query TopSites if SuggestionsService has nothing in the cache

BUG=596857

Committed: https://crrev.com/ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d
Cr-Commit-Position: refs/heads/master@{#384260}
==========

[commit-bot: I haz the power, 2016-03-31 13:27:50]

Patchset 1 (id:??) landed as
https://crrev.com/ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d
Cr-Commit-Position: refs/heads/master@{#384260}