Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1850673002: Android NTP: only query TopSites if SuggestionsService has nothing in the cache (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android NTP: only query TopSites if SuggestionsService has nothing in the cache BUG=596857 Committed: https://crrev.com/ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d Cr-Commit-Position: refs/heads/master@{#384260}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.cc View 2 chunks +17 lines, -6 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850673002/1
4 years, 8 months ago (2016-03-31 12:22:46 UTC) #2
Marc Treib
PTAL! https://codereview.chromium.org/1850673002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc File chrome/browser/android/ntp/most_visited_sites.cc (left): https://codereview.chromium.org/1850673002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc#oldcode421 chrome/browser/android/ntp/most_visited_sites.cc:421: if (!suggestions_service->FetchSuggestionsData()) What happened before is: This got ...
4 years, 8 months ago (2016-03-31 12:26:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 13:08:08 UTC) #6
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-03-31 13:16:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850673002/1
4 years, 8 months ago (2016-03-31 13:21:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 13:26:13 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 13:27:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d
Cr-Commit-Position: refs/heads/master@{#384260}

Powered by Google App Engine
This is Rietveld 408576698