Provide ability to patch external functions in a class that has already been finalized. The follow…

runtime/vm/object.h

Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 8a818f64b0353bc2ddc39183286d0f73890a9f79..4a08dbabeb20750cd7f0ea13055223b9d6a688e3 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -1265,6 +1265,12 @@ class Class : public Object {
 
   void set_is_prefinalized() const;
 
+  bool is_refinalize() const {
+    return ClassFinalizedBits::decode(raw_ptr()->state_bits_)
+        == RawClass::kRefinalize;
+  }
+
+  void SetRefinalize() const;
   void ResetFinalization() const;

[regis, 2016/03/31 18:16:49]

The two calls SetRefinalize and ResetFinalization could easily be mixed up. A
few suggestions for more specific names:
SetRefinalizeAfterPatch
SetRefinalizePatched
SetPatchedUnfinalized
SetPostFinalizedPatched (to use your own term).

The state bit should be renamed accordingly.

[siva, 2016/03/31 23:48:08]

I went with SetRefinalizeAfterPatch (a bit verbose but very clear).

 
   bool is_marked_for_parsing() const {
@@ -1378,6 +1384,8 @@ class Class : public Object {
   bool TraceAllocation(Isolate* isolate) const;
   void SetTraceAllocation(bool trace_allocation) const;
 
+  bool ValidatePostFinalizePatch(const Class& orig_class, Error* error) const;
+
  private:
   enum MemberKind {
     kAny = 0,