Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1850643002: Adding %_NewObject intrinsic (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding %_NewObject intrinsic This should help speeding up Promise and RegExp instantiations substantially. BUG= Committed: https://crrev.com/942f255fa2573eb3bb09390e7e213c472e03d962 Cr-Commit-Position: refs/heads/master@{#35200}

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressing comments #

Total comments: 1

Patch Set 3 : using new approach #

Patch Set 4 : the ultimate args permutation for NewNode #

Total comments: 1

Patch Set 5 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/js/promise.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/string.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850643002/1
4 years, 8 months ago (2016-03-31 12:03:19 UTC) #2
Camillo Bruni
PTAL some low-hanging fruit here ;)
4 years, 8 months ago (2016-03-31 12:04:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 12:25:50 UTC) #6
Benedikt Meurer
Nice. Looking good, just two lowering changes. https://codereview.chromium.org/1850643002/diff/1/src/compiler/js-intrinsic-lowering.cc File src/compiler/js-intrinsic-lowering.cc (right): https://codereview.chromium.org/1850643002/diff/1/src/compiler/js-intrinsic-lowering.cc#newcode483 src/compiler/js-intrinsic-lowering.cc:483: return Change(node, ...
4 years, 8 months ago (2016-03-31 17:49:29 UTC) #7
Camillo Bruni
PTAL again https://codereview.chromium.org/1850643002/diff/1/src/full-codegen/full-codegen.cc File src/full-codegen/full-codegen.cc (right): https://codereview.chromium.org/1850643002/diff/1/src/full-codegen/full-codegen.cc#newcode511 src/full-codegen/full-codegen.cc:511: // Load the arguments on the stack ...
4 years, 8 months ago (2016-04-01 10:44:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850643002/60001
4 years, 8 months ago (2016-04-01 10:44:22 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-01 10:44:24 UTC) #12
Benedikt Meurer
LGTM, thanks.
4 years, 8 months ago (2016-04-01 10:56:44 UTC) #13
Michael Starzinger
https://codereview.chromium.org/1850643002/diff/60001/src/compiler/linkage.cc File src/compiler/linkage.cc (right): https://codereview.chromium.org/1850643002/diff/60001/src/compiler/linkage.cc#newcode174 src/compiler/linkage.cc:174: case Runtime::kInlineNewObject: nit: Please keep list alpha-sorted.
4 years, 8 months ago (2016-04-01 10:57:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850643002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850643002/80001
4 years, 8 months ago (2016-04-01 11:06:48 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-01 11:33:59 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 11:34:32 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/942f255fa2573eb3bb09390e7e213c472e03d962
Cr-Commit-Position: refs/heads/master@{#35200}

Powered by Google App Engine
This is Rietveld 408576698