Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1850623005: Issue 26147. Don't attempt to set the type of the parameter for setters without parameters. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26147. Don't attempt to set the type of the parameter for setters without parameters. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26147 Committed: https://github.com/dart-lang/sdk/commit/fd4e357413b0827ad5148c9b8c8d624fa733999d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-03-31 20:32:49 UTC) #1
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-03-31 20:42:35 UTC) #2
scheglov
4 years, 8 months ago (2016-03-31 20:46:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd4e357413b0827ad5148c9b8c8d624fa733999d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698