Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1850623004: Create .mojo applications in a common subdir under out/Debug (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create .mojo applications in a common subdir under out/Debug R=sky@chromium.org BUG= Committed: https://crrev.com/925b73fc6bde4ecb132248bc96b99a3e865e15c2 Cr-Commit-Position: refs/heads/master@{#384779}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M components/mus/BUILD.gn View 1 2 3 5 chunks +5 lines, -4 lines 0 comments Download
M components/resource_provider/file_utils.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/mojo_application.gni View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/mojo_application_manifest.gni View 3 chunks +4 lines, -2 lines 0 comments Download
A mojo/public/mojo_constants.gni View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/services/catalog/catalog.cc View 1 2 3 4 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (10 generated)
Ben Goodger (Google)
4 years, 8 months ago (2016-03-31 19:12:14 UTC) #1
sky
I'm pretty sure you'll need to update the resource_provider too. Be sure and try this ...
4 years, 8 months ago (2016-03-31 19:37:48 UTC) #2
Ben Goodger (Google)
Updated
4 years, 8 months ago (2016-03-31 20:41:44 UTC) #3
sky
LGTM https://codereview.chromium.org/1850623004/diff/20001/components/resource_provider/file_utils.cc File components/resource_provider/file_utils.cc (right): https://codereview.chromium.org/1850623004/diff/20001/components/resource_provider/file_utils.cc#newcode73 components/resource_provider/file_utils.cc:73: return base_path.AppendASCII("Mojo Applications").AppendASCII(path). How about putting this in ...
4 years, 8 months ago (2016-03-31 20:58:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850623004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850623004/40001
4 years, 8 months ago (2016-04-01 18:00:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/138225)
4 years, 8 months ago (2016-04-01 18:28:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850623004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850623004/60001
4 years, 8 months ago (2016-04-01 21:28:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850623004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850623004/80001
4 years, 8 months ago (2016-04-01 22:48:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/47212)
4 years, 8 months ago (2016-04-01 23:36:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850623004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850623004/80001
4 years, 8 months ago (2016-04-02 00:38:41 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-02 01:37:50 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 01:38:53 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/925b73fc6bde4ecb132248bc96b99a3e865e15c2
Cr-Commit-Position: refs/heads/master@{#384779}

Powered by Google App Engine
This is Rietveld 408576698