Issue 1850603002: [tracing] Use trace event profiling for heap profiling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1850603002: [tracing] Use trace event profiling for heap profiling

Created:
4 years, 8 months ago by ssid

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, blink-reviews-events_chromium.org, wfh+watch_chromium.org, eae+blinkwatch, blink-reviews, dglazkov+blink, tracing+reviews_chromium.org, kinuko+watch

Base URL:
https://chromium.googlesource.com/chromium/src.git@all_categories

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[tracing] Use trace event profiling for heap profiling This CL follows changes in crrev.com/1837013003: - Implement the same in Webkit. - Add stack frame to pseudo stack in trace event. - Do not add to stack from TraceLog::AddTraceEvent for these events. This CL implements the platform functions added for: - V8 in crrev.com/1848703002 - Skia in crrev.com/1849453005 BUG=598426

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -61 lines)			Patch
M	base/trace_event/trace_event.h	View	2 chunks	+12 lines, -8 lines	0 comments	Download
M	base/trace_event/trace_log.cc	View	3 chunks	+31 lines, -29 lines	0 comments	Download
M	gin/public/v8_platform.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gin/v8_platform.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	skia/ext/event_tracer_impl.cc	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/EventTracer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/EventTracer.cpp	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/TraceEvent.h	View	5 chunks	+59 lines, -24 lines	0 comments	Download

Depends on Patchset:

Issue 1837013003 Patch 120001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ssid

4 years, 8 months ago (2016-03-31 04:11:50 UTC) #1

Description was changed from

==========
[tracing] Add support for profiling trace events

This CL follows changes in crrev.com/1837013003:
 - Implement the same in Webkit.
 - Add stack frame to pseudo stack in trace event.
 - Do not add to stack from TraceLog::AddTraceEvent for these events.

This CL implements the platform functions added for:
- V8 in crrev.com/1848703002
- Skia in crrev.com/1849453005

BUG=598426
==========

to

==========
[tracing] Use trace event profiling for heap profiling

This CL follows changes in crrev.com/1837013003:
 - Implement the same in Webkit.
 - Add stack frame to pseudo stack in trace event.
 - Do not add to stack from TraceLog::AddTraceEvent for these events.

This CL implements the platform functions added for:
- V8 in crrev.com/1848703002
- Skia in crrev.com/1849453005

BUG=598426
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages