Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213
Committed: https://crrev.com/fad9cf0f060000c0ac5a65133b3254cf54c6b96e
Cr-Commit-Position: refs/heads/master@{#384372}

[lazyboy, 2016-03-31 15:36:12]

Description was changed from

==========
Enable ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=
==========

to

==========
Enable ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213
==========

[lazyboy, 2016-03-31 15:36:31]

Description was changed from

==========
Enable ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213
==========

to

==========
Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213
==========

[lazyboy, 2016-03-31 15:39:36]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[lazyboy, 2016-03-31 15:39:37]

FYI, I've made sure the flakiness is gone, see trybot runs in patch set #2 where
I've run the test 200 times on bots, didn't see any failure. For example:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...

[Devlin, 2016-03-31 16:52:56]

lgtm, thanks for the speedy turnaround! :)

https://codereview.chromium.org/1850593002/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/runtime/open_options_page/test.js
(right):

https://codereview.chromium.org/1850593002/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/runtime/open_options_page/test.js:33:
chrome.runtime.openOptionsPage(callbackPass(function() {}));
nit: the function argument in callbackPass is optional, so this can just be
callbackPass().

[lazyboy, 2016-03-31 19:23:51]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-03-31 19:23:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1850593002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2016-03-31 19:24:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850593002/60001

[commit-bot: I haz the power, 2016-03-31 20:36:02]

Description was changed from

==========
Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213
==========

to

==========
Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213
==========

[commit-bot: I haz the power, 2016-03-31 20:36:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-31 20:37:36]

Description was changed from

==========
Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213
==========

to

==========
Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG=599213

Committed: https://crrev.com/fad9cf0f060000c0ac5a65133b3254cf54c6b96e
Cr-Commit-Position: refs/heads/master@{#384372}
==========

[commit-bot: I haz the power, 2016-03-31 20:37:37]

Patchset 4 (id:??) landed as
https://crrev.com/fad9cf0f060000c0ac5a65133b3254cf54c6b96e
Cr-Commit-Position: refs/heads/master@{#384372}