Split cross-process transfer tests out of SitePerProcessBrowserTest.

Split cross-process transfer tests out of SitePerProcessBrowserTest.

BUG=none
R=mmenke@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255489

[Charlie Reis, 2014-03-06 05:18:06]

mmenke: Here's followup from https://codereview.chromium.org/143183009/, where
we talked about splitting the transfer tests out into their own class.  That
keeps SitePerProcessBrowserTest about behavior actually gated by the flag.  (The
new CrossSiteTransferTest just happens to use the flag to force process swaps.)

(CC'ing @davidben as FYI for future tests.)

[mmenke, 2014-03-06 18:40:54]

Can you modify git's same-file threshold, so this looks like a copy rather than
a new file?  I think that's more accurate, and it'll make this much easier to
review.

https://codereview.chromium.org/185053007/diff/1/content/browser/cross_site_t...
File content/browser/cross_site_transfer_browsertest.cc (right):

https://codereview.chromium.org/185053007/diff/1/content/browser/cross_site_t...
content/browser/cross_site_transfer_browsertest.cc:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
Since this is largely copying old code, should we use the old copyright date or
a new one?

[Charlie Reis, 2014-03-06 18:42:15]

On 2014/03/06 18:40:54, mmenke wrote:
> Can you modify git's same-file threshold, so this looks like a copy rather
than
> a new file?  I think that's more accurate, and it'll make this much easier to
> review.

Sorry, my git skills aren't that advanced.  How do you do that?

[mmenke, 2014-03-06 18:45:05]

On 2014/03/06 18:42:15, Charlie Reis wrote:
> On 2014/03/06 18:40:54, mmenke wrote:
> > Can you modify git's same-file threshold, so this looks like a copy rather
> than
> > a new file?  I think that's more accurate, and it'll make this much easier
to
> > review.
> 
> Sorry, my git skills aren't that advanced.  How do you do that?

I use SVN, so I don't know off the top of my head, but looking through my old
email, it looks like "git cl upload
--similarity 40"  (Or some other number instead of 40, lower makes matching more
likely).

And I'm sorry I didn't do this myself - I got sidetracked on another CL, and
this completely dropped off my radar.

[Charlie Reis, 2014-03-06 18:50:23]

Thanks, that does look easier to read.  PTAL.

https://codereview.chromium.org/185053007/diff/1/content/browser/cross_site_t...
File content/browser/cross_site_transfer_browsertest.cc (right):

https://codereview.chromium.org/185053007/diff/1/content/browser/cross_site_t...
content/browser/cross_site_transfer_browsertest.cc:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/03/06 18:40:54, mmenke wrote:
> Since this is largely copying old code, should we use the old copyright date
or
> a new one?

Done.

[mmenke, 2014-03-06 20:11:14]

LGTM, just suggestions about headers.  Kind of amusing how the two sets of tests
shared so little code.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
File content/browser/cross_site_transfer_browsertest.cc (right):

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:7: #include
"base/strings/utf_string_conversions.h"
I don't think this is used in this file (or the other one, for that matter)

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:9: #include
"content/browser/renderer_host/render_view_host_impl.h"
I don't think we need this one.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:10: #include
"content/browser/web_contents/web_contents_impl.h"
The other file needs this, but this one just needs public/web_contents.h, so I
suggest we use that instead.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:14: #include
"content/public/browser/notification_types.h"
None of these notification files are used.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:17: #include
"content/public/browser/web_contents_observer.h"
I don't think this is used.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:19: #include
"content/public/common/url_constants.h"
I don't believe this is used in either file.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:22: #include
"content/public/test/test_utils.h"
I don't believe we're using this one.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:31: #include
"net/url_request/url_request_status.h"
May want to add the GURL header (both files?).

[Charlie Reis, 2014-03-06 22:20:11]

Thanks-- it's nice to trim those down.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
File content/browser/cross_site_transfer_browsertest.cc (right):

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:7: #include
"base/strings/utf_string_conversions.h"
On 2014/03/06 20:11:14, mmenke wrote:
> I don't think this is used in this file (or the other one, for that matter)

Done.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:9: #include
"content/browser/renderer_host/render_view_host_impl.h"
On 2014/03/06 20:11:14, mmenke wrote:
> I don't think we need this one.

Done.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:10: #include
"content/browser/web_contents/web_contents_impl.h"
On 2014/03/06 20:11:14, mmenke wrote:
> The other file needs this, but this one just needs public/web_contents.h, so I
> suggest we use that instead.

Done.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:14: #include
"content/public/browser/notification_types.h"
On 2014/03/06 20:11:14, mmenke wrote:
> None of these notification files are used.

Done.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:17: #include
"content/public/browser/web_contents_observer.h"
On 2014/03/06 20:11:14, mmenke wrote:
> I don't think this is used.

Done.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:19: #include
"content/public/common/url_constants.h"
On 2014/03/06 20:11:14, mmenke wrote:
> I don't believe this is used in either file.

Done.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:22: #include
"content/public/test/test_utils.h"
On 2014/03/06 20:11:14, mmenke wrote:
> I don't believe we're using this one.

Done.

https://codereview.chromium.org/185053007/diff/30001/content/browser/cross_si...
content/browser/cross_site_transfer_browsertest.cc:31: #include
"net/url_request/url_request_status.h"
On 2014/03/06 20:11:14, mmenke wrote:
> May want to add the GURL header (both files?).

Done.

[Charlie Reis, 2014-03-06 22:20:19]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2014-03-06 22:33:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/185053007/80001

[commit-bot: I haz the power, 2014-03-07 00:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 00:23:25]

Try jobs failed on following builders: mac_chromium_compile_dbg

[Charlie Reis, 2014-03-07 01:28:43]

Committed patchset #4 manually as r255489 (presubmit successful).