Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18505003: Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, f(malita), pdr, Stephen Chennney, do-not-use, lgombos, krit
Visibility:
Public.

Description

Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG and use Web IDL implements instead to get rid of multiple inheritance and follow the latest specification: http://www.w3.org/TR/filter-effects/#DOMInterfaces There is no web-exposed behavior change. BUG=256618 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -35 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGFEBlendElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFECompositeElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEFloodElement.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEMergeElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEOffsetElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFETileElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-02 13:42:15 UTC) #1
haraken
LGTM
7 years, 5 months ago (2013-07-02 13:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18505003/1
7 years, 5 months ago (2013-07-02 13:44:44 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 15:13:42 UTC) #4
Message was sent while issue was closed. 
Change committed as 153426

Powered by Google App Engine
This is Rietveld 408576698