Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: cc/trees/damage_tracker_unittest.cc

Issue 1850493002: cc : Remove parent for mask and replica layers in LayerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete dead code Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer_impl.cc ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/damage_tracker_unittest.cc
diff --git a/cc/trees/damage_tracker_unittest.cc b/cc/trees/damage_tracker_unittest.cc
index 743631f2bca1c67b190a74c7cc34cb1979a58048..65775beb9df19fecf97a150e20b4a6b540d75877 100644
--- a/cc/trees/damage_tracker_unittest.cc
+++ b/cc/trees/damage_tracker_unittest.cc
@@ -1392,6 +1392,7 @@ TEST_F(DamageTrackerTest, VerifyDamageForReplicaMaskWithTransformOrigin) {
gfx::Transform reflection;
reflection.Scale3d(-1.0, 1.0, 1.0);
grand_child1_replica->SetTransform(reflection);
+ grand_child1_replica->SetParent(grand_child1);
ajuma 2016/03/30 21:56:05 Why do tests still need to set the parent of mask
jaydasika 2016/03/30 21:59:32 We don't need parent for masks but need it for rep
ajuma 2016/03/30 22:02:52 Oh, ok. Do we have other tests that construct repl
jaydasika 2016/03/30 22:10:08 There are many tests. One random example : LayerTr
ajuma 2016/03/30 23:00:09 Thanks for checking. Please add a comment here (an
jaydasika 2016/03/30 23:29:46 Done.
grand_child1->SetReplicaLayer(std::move(grand_child1_replica));
grand_child1->SetForceRenderSurface(true);
}
« no previous file with comments | « cc/layers/layer_impl.cc ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698