cc : Remove parent for mask and replica layers in LayerImpl

cc : Remove parent for mask and replica layers in LayerImpl

This CL also deletes some dead code.

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5017a33b6604deeb741251f845955c097b07baf3
Cr-Commit-Position: refs/heads/master@{#384172}

[jaydasika, 2016-03-30 21:19:39]

Description was changed from

==========
cc : Remove parent for mask and replica layers in LayerImpl

BUG=599170
==========

to

==========
cc : Remove parent for mask and replica layers in LayerImpl

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-03-30 21:26:12]

Description was changed from

==========
cc : Remove parent for mask and replica layers in LayerImpl

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Remove parent for mask and replica layers in LayerImpl

This CL also deletes some dead code.

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-03-30 21:26:12]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-03-30 21:26:41]

PTAL

[ajuma, 2016-03-30 21:56:05]

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
File cc/trees/damage_tracker_unittest.cc (right):

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
cc/trees/damage_tracker_unittest.cc:1395:
grand_child1_replica->SetParent(grand_child1);
Why do tests still need to set the parent of mask and replica layers?

[jaydasika, 2016-03-30 21:59:32]

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
File cc/trees/damage_tracker_unittest.cc (right):

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
cc/trees/damage_tracker_unittest.cc:1395:
grand_child1_replica->SetParent(grand_child1);
On 2016/03/30 21:56:05, ajuma wrote:
> Why do tests still need to set the parent of mask and replica layers?

We don't need parent for masks but need it for replica's as we build property
trees for replicas. (I mean replicas are part of the recursion of building
property trees like other children).

[ajuma, 2016-03-30 22:02:52]

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
File cc/trees/damage_tracker_unittest.cc (right):

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
cc/trees/damage_tracker_unittest.cc:1395:
grand_child1_replica->SetParent(grand_child1);
On 2016/03/30 21:59:32, jaydasika wrote:
> On 2016/03/30 21:56:05, ajuma wrote:
> > Why do tests still need to set the parent of mask and replica layers?
> 
> We don't need parent for masks but need it for replica's as we build property
> trees for replicas. (I mean replicas are part of the recursion of building
> property trees like other children).

Oh, ok. Do we have other tests that construct replicas on the main thread rather
than on LayerImpl? (Just want to make sure we have test coverage for replica
LayerImpls that aren't children of any layer.)

[jaydasika, 2016-03-30 22:10:09]

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
File cc/trees/damage_tracker_unittest.cc (right):

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
cc/trees/damage_tracker_unittest.cc:1395:
grand_child1_replica->SetParent(grand_child1);
On 2016/03/30 22:02:52, ajuma wrote:
> On 2016/03/30 21:59:32, jaydasika wrote:
> > On 2016/03/30 21:56:05, ajuma wrote:
> > > Why do tests still need to set the parent of mask and replica layers?
> > 
> > We don't need parent for masks but need it for replica's as we build
property
> > trees for replicas. (I mean replicas are part of the recursion of building
> > property trees like other children).
> 
> Oh, ok. Do we have other tests that construct replicas on the main thread
rather
> than on LayerImpl? (Just want to make sure we have test coverage for replica
> LayerImpls that aren't children of any layer.)

There are many tests. One random example :
LayerTreeHostMasksPixelTest.MaskWithReplicaOfClippedLayer

[ajuma, 2016-03-30 23:00:09]

lgtm

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
File cc/trees/damage_tracker_unittest.cc (right):

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
cc/trees/damage_tracker_unittest.cc:1395:
grand_child1_replica->SetParent(grand_child1);
On 2016/03/30 22:10:08, jaydasika wrote:
> On 2016/03/30 22:02:52, ajuma wrote:
> > On 2016/03/30 21:59:32, jaydasika wrote:
> > > On 2016/03/30 21:56:05, ajuma wrote:
> > > > Why do tests still need to set the parent of mask and replica layers?
> > > 
> > > We don't need parent for masks but need it for replica's as we build
> property
> > > trees for replicas. (I mean replicas are part of the recursion of building
> > > property trees like other children).
> > 
> > Oh, ok. Do we have other tests that construct replicas on the main thread
> rather
> > than on LayerImpl? (Just want to make sure we have test coverage for replica
> > LayerImpls that aren't children of any layer.)
> 
> There are many tests. One random example :
> LayerTreeHostMasksPixelTest.MaskWithReplicaOfClippedLayer

Thanks for checking. Please add a comment here (and in the other tests) that
this is only needed for property tree building.

[jaydasika, 2016-03-30 23:29:46]

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
File cc/trees/damage_tracker_unittest.cc (right):

https://codereview.chromium.org/1850493002/diff/20001/cc/trees/damage_tracker...
cc/trees/damage_tracker_unittest.cc:1395:
grand_child1_replica->SetParent(grand_child1);
On 2016/03/30 23:00:09, ajuma wrote:
> On 2016/03/30 22:10:08, jaydasika wrote:
> > On 2016/03/30 22:02:52, ajuma wrote:
> > > On 2016/03/30 21:59:32, jaydasika wrote:
> > > > On 2016/03/30 21:56:05, ajuma wrote:
> > > > > Why do tests still need to set the parent of mask and replica layers?
> > > > 
> > > > We don't need parent for masks but need it for replica's as we build
> > property
> > > > trees for replicas. (I mean replicas are part of the recursion of
building
> > > > property trees like other children).
> > > 
> > > Oh, ok. Do we have other tests that construct replicas on the main thread
> > rather
> > > than on LayerImpl? (Just want to make sure we have test coverage for
replica
> > > LayerImpls that aren't children of any layer.)
> > 
> > There are many tests. One random example :
> > LayerTreeHostMasksPixelTest.MaskWithReplicaOfClippedLayer
> 
> Thanks for checking. Please add a comment here (and in the other tests) that
> this is only needed for property tree building.

Done.

[jaydasika, 2016-03-30 23:29:51]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-03-30 23:29:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1850493002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-30 23:30:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850493002/40001

[commit-bot: I haz the power, 2016-03-31 01:06:30]

Description was changed from

==========
cc : Remove parent for mask and replica layers in LayerImpl

This CL also deletes some dead code.

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Remove parent for mask and replica layers in LayerImpl

This CL also deletes some dead code.

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-31 01:06:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-31 01:11:00]

Description was changed from

==========
cc : Remove parent for mask and replica layers in LayerImpl

This CL also deletes some dead code.

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Remove parent for mask and replica layers in LayerImpl

This CL also deletes some dead code.

BUG=599170
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5017a33b6604deeb741251f845955c097b07baf3
Cr-Commit-Position: refs/heads/master@{#384172}
==========

[commit-bot: I haz the power, 2016-03-31 01:11:01]

Patchset 3 (id:??) landed as
https://crrev.com/5017a33b6604deeb741251f845955c097b07baf3
Cr-Commit-Position: refs/heads/master@{#384172}