Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1850483002: Explicitly declare a method in WebContentsViewCocoa. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly declare a method in WebContentsViewCocoa. The method -[NSObject draggingSourceOperationMaskForLocal:] is marked as deprecated, but the non-deprecated API -[NSWindow dragImage:...] still relies on it. Explicitly declaring the method in the public interface for WebContentsViewCocoa allows the method to be called from a test without warnings. BUG=592663 Committed: https://crrev.com/ea4f3aa835f5de37682a3339fd51d8bbc428d373 Cr-Commit-Position: refs/heads/master@{#384330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/web_contents/web_contents_view_mac.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
erikchen
mark: Please review.
4 years, 8 months ago (2016-03-30 20:42:30 UTC) #3
Mark Mentovai
LGTM
4 years, 8 months ago (2016-03-30 20:57:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850483002/1
4 years, 8 months ago (2016-03-30 20:59:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/162207)
4 years, 8 months ago (2016-03-30 21:08:57 UTC) #8
erikchen
avi: Please review.
4 years, 8 months ago (2016-03-30 21:47:33 UTC) #10
Avi (use Gerrit)
lgtm joy.
4 years, 8 months ago (2016-03-30 22:05:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850483002/1
4 years, 8 months ago (2016-03-31 17:59:53 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 18:12:05 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:13:29 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea4f3aa835f5de37682a3339fd51d8bbc428d373
Cr-Commit-Position: refs/heads/master@{#384330}

Powered by Google App Engine
This is Rietveld 408576698