Revert of Patch to try dump-on-DCHECK.

Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of https://codereview.chromium.org/1814423002/ )

Reason for revert:
Speculative, looks like this breaks Google Chrome Win: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/5653

obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error LNK1107: invalid or corrupt file: cannot read at 0x62BBDB03

(To repro, you probably need to do an official build to trigger PGO)

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231
Committed: https://crrev.com/be0116796008e81aa179f6e41fe05f5225ff1c6a
Cr-Commit-Position: refs/heads/master@{#384056}

[Nico, 2016-03-30 19:34:22]

Created Revert of Patch to try dump-on-DCHECK.

[commit-bot: I haz the power, 2016-03-30 19:35:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850473002/1

[commit-bot: I haz the power, 2016-03-30 19:35:44]

Description was changed from

==========
Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
Speculative, looks like this breaks Google Chrome Win:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error LNK1107:
invalid or corrupt file: cannot read at 0x62BBDB03

(To repro, you probably need to do an official build to trigger PGO)

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231
==========

to

==========
Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
Speculative, looks like this breaks Google Chrome Win:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error LNK1107:
invalid or corrupt file: cannot read at 0x62BBDB03

(To repro, you probably need to do an official build to trigger PGO)

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231
==========

[commit-bot: I haz the power, 2016-03-30 19:35:45]

Committed patchset #1 (id:1)

[Wez, 2016-03-30 19:57:29]

As was noted on the original CL, Bruce believes that this is toolchain
flake, so we want to try a clobber build, NOT revert.

On 30 March 2016 at 12:35, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Committed patchset #1 (id:1)
>
> https://codereview.chromium.org/1850473002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-03-30 20:05:25]

Description was changed from

==========
Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
Speculative, looks like this breaks Google Chrome Win:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error LNK1107:
invalid or corrupt file: cannot read at 0x62BBDB03

(To repro, you probably need to do an official build to trigger PGO)

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231
==========

to

==========
Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
Speculative, looks like this breaks Google Chrome Win:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error LNK1107:
invalid or corrupt file: cannot read at 0x62BBDB03

(To repro, you probably need to do an official build to trigger PGO)

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231

Committed: https://crrev.com/be0116796008e81aa179f6e41fe05f5225ff1c6a
Cr-Commit-Position: refs/heads/master@{#384056}
==========

[commit-bot: I haz the power, 2016-03-30 20:05:26]

Patchset 1 (id:??) landed as
https://crrev.com/be0116796008e81aa179f6e41fe05f5225ff1c6a
Cr-Commit-Position: refs/heads/master@{#384056}

[Nico, 2016-03-30 20:10:59]

On 2016/03/30 19:57:29, Wez wrote:
> As was noted on the original CL, Bruce believes that this is toolchain
> flake, so we want to try a clobber build, NOT revert.

Yeah, but then this failed 4 times in a row when your CL landed and greened up
after the revert, so Bruce's belief wasn't correct.

The official bots always clobber on every build, so clobbering wouldn't have
helped. See also https://crbug.com/599186

[Wez, 2016-03-30 20:14:32]

Yes; looks like a systematic failure that (surprise surprise) doesn't repro
locally. ;-(

Thanks for the extra context.

On 30 March 2016 at 13:10, <thakis@chromium.org> wrote:

> On 2016/03/30 19:57:29, Wez wrote:
> > As was noted on the original CL, Bruce believes that this is toolchain
> > flake, so we want to try a clobber build, NOT revert.
>
> Yeah, but then this failed 4 times in a row when your CL landed and
> greened up
> after the revert, so Bruce's belief wasn't correct.
>
> The official bots always clobber on every build, so clobbering wouldn't
> have
> helped. See also https://crbug.com/599186
>
> https://codereview.chromium.org/1850473002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 20:15:13]

I bet it repros if you do an official build.

On Wed, Mar 30, 2016 at 4:14 PM, Wez <wez@chromium.org> wrote:

> Yes; looks like a systematic failure that (surprise surprise) doesn't
> repro locally. ;-(
>
> Thanks for the extra context.
>
> On 30 March 2016 at 13:10, <thakis@chromium.org> wrote:
>
>> On 2016/03/30 19:57:29, Wez wrote:
>> > As was noted on the original CL, Bruce believes that this is toolchain
>> > flake, so we want to try a clobber build, NOT revert.
>>
>> Yeah, but then this failed 4 times in a row when your CL landed and
>> greened up
>> after the revert, so Bruce's belief wasn't correct.
>>
>> The official bots always clobber on every build, so clobbering wouldn't
>> have
>> helped. See also https://crbug.com/599186
>>
>> https://codereview.chromium.org/1850473002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 20:15:24]

(it repro'd for grt at least.)

On Wed, Mar 30, 2016 at 4:15 PM, Nico Weber <thakis@chromium.org> wrote:

> I bet it repros if you do an official build.
>
> On Wed, Mar 30, 2016 at 4:14 PM, Wez <wez@chromium.org> wrote:
>
>> Yes; looks like a systematic failure that (surprise surprise) doesn't
>> repro locally. ;-(
>>
>> Thanks for the extra context.
>>
>> On 30 March 2016 at 13:10, <thakis@chromium.org> wrote:
>>
>>> On 2016/03/30 19:57:29, Wez wrote:
>>> > As was noted on the original CL, Bruce believes that this is toolchain
>>> > flake, so we want to try a clobber build, NOT revert.
>>>
>>> Yeah, but then this failed 4 times in a row when your CL landed and
>>> greened up
>>> after the revert, so Bruce's belief wasn't correct.
>>>
>>> The official bots always clobber on every build, so clobbering wouldn't
>>> have
>>> helped. See also https://crbug.com/599186
>>>
>>> https://codereview.chromium.org/1850473002/
>>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Wez, 2016-03-30 20:20:09]

I'm already doing an official build; I'm clobbering & rebuilding w/ the
same -j parameter in case it's an issue w/ parallel link resource
consumption or something painful like that.

On 30 March 2016 at 13:15, Nico Weber <thakis@chromium.org> wrote:

> (it repro'd for grt at least.)
>
> On Wed, Mar 30, 2016 at 4:15 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> I bet it repros if you do an official build.
>>
>> On Wed, Mar 30, 2016 at 4:14 PM, Wez <wez@chromium.org> wrote:
>>
>>> Yes; looks like a systematic failure that (surprise surprise) doesn't
>>> repro locally. ;-(
>>>
>>> Thanks for the extra context.
>>>
>>> On 30 March 2016 at 13:10, <thakis@chromium.org> wrote:
>>>
>>>> On 2016/03/30 19:57:29, Wez wrote:
>>>> > As was noted on the original CL, Bruce believes that this is toolchain
>>>> > flake, so we want to try a clobber build, NOT revert.
>>>>
>>>> Yeah, but then this failed 4 times in a row when your CL landed and
>>>> greened up
>>>> after the revert, so Bruce's belief wasn't correct.
>>>>
>>>> The official bots always clobber on every build, so clobbering wouldn't
>>>> have
>>>> helped. See also https://crbug.com/599186
>>>>
>>>> https://codereview.chromium.org/1850473002/
>>>>
>>>
>>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 20:28:02]

How are you doing an official build?

On Wed, Mar 30, 2016 at 4:20 PM, Wez <wez@chromium.org> wrote:

> I'm already doing an official build; I'm clobbering & rebuilding w/ the
> same -j parameter in case it's an issue w/ parallel link resource
> consumption or something painful like that.
>
> On 30 March 2016 at 13:15, Nico Weber <thakis@chromium.org> wrote:
>
>> (it repro'd for grt at least.)
>>
>> On Wed, Mar 30, 2016 at 4:15 PM, Nico Weber <thakis@chromium.org> wrote:
>>
>>> I bet it repros if you do an official build.
>>>
>>> On Wed, Mar 30, 2016 at 4:14 PM, Wez <wez@chromium.org> wrote:
>>>
>>>> Yes; looks like a systematic failure that (surprise surprise) doesn't
>>>> repro locally. ;-(
>>>>
>>>> Thanks for the extra context.
>>>>
>>>> On 30 March 2016 at 13:10, <thakis@chromium.org> wrote:
>>>>
>>>>> On 2016/03/30 19:57:29, Wez wrote:
>>>>> > As was noted on the original CL, Bruce believes that this is
>>>>> toolchain
>>>>> > flake, so we want to try a clobber build, NOT revert.
>>>>>
>>>>> Yeah, but then this failed 4 times in a row when your CL landed and
>>>>> greened up
>>>>> after the revert, so Bruce's belief wasn't correct.
>>>>>
>>>>> The official bots always clobber on every build, so clobbering
>>>>> wouldn't have
>>>>> helped. See also https://crbug.com/599186
>>>>>
>>>>> https://codereview.chromium.org/1850473002/
>>>>>
>>>>
>>>>
>>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 20:45:21]

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
has:

set GYP_DEFINES=branding=Chrome buildtype=Official use_goma=1
gomadir='C:\b\build\goma' fastbuild=1 target_arch=ia32

(but what you have should repro too)