third_party/WebKit/Source/core/css/CSSPathValue.cpp - Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPathValue.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address compilation failure Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSPathValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPathValue.cpp b/third_party/WebKit/Source/core/css/CSSPathValue.cpp

index 8b0bab4fa2f65c8842a23e1a5517b3dc40ef23b7..43421478e261c8400c94ec18799ad3873a9b02b4 100644

--- a/third_party/WebKit/Source/core/css/CSSPathValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPathValue.cpp

@@ -39,10 +39,10 @@ RawPtr<CSSPathValue> createPathValue()

} // namespace

-CSSPathValue* CSSPathValue::emptyPathValue()

+CSSPathValue& CSSPathValue::emptyPathValue()

{

- DEFINE_STATIC_LOCAL(Persistent<CSSPathValue>, empty, (createPathValue()));

- return empty.get();

+ DEFINE_STATIC_LOCAL(CSSPathValue, empty, (createPathValue()));

+ return empty;

}

String CSSPathValue::customCSSText() const

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPathValue.h ('k') | third_party/WebKit/Source/core/css/CSSValuePool.cpp » ('j') | no next file with comments »