third_party/WebKit/Source/web/InspectorOverlay.cpp - Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add HeapTest unit test + rebase upto r384858. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/heap/HeapTest.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | third_party/WebKit/Source/wtf/StdLibExtras.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/InspectorOverlay.cpp

diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp

index cff0af0bfb9c1ac3b43265a717b4637c32736997..7a944723a7a02b4ef0a37991bb3579bc6d65aa34 100644

--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp

+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp

@@ -468,7 +468,7 @@ Page* InspectorOverlay::overlayPage()

ScriptForbiddenScope::AllowUserAgentScript allowScript;

- DEFINE_STATIC_LOCAL(Persistent<FrameLoaderClient>, dummyFrameLoaderClient, (EmptyFrameLoaderClient::create()));

+ DEFINE_STATIC_LOCAL(FrameLoaderClient, dummyFrameLoaderClient, (EmptyFrameLoaderClient::create()));

Page::PageClients pageClients;

fillWithEmptyClients(pageClients);

DCHECK(!m_overlayChromeClient);

@@ -495,7 +495,7 @@ Page* InspectorOverlay::overlayPage()

// through some non-composited paint function.

overlaySettings.setAcceleratedCompositingEnabled(false);

- RawPtr<LocalFrame> frame = LocalFrame::create(dummyFrameLoaderClient.get(), &m_overlayPage->frameHost(), 0);

+ RawPtr<LocalFrame> frame = LocalFrame::create(&dummyFrameLoaderClient, &m_overlayPage->frameHost(), 0);

frame->setView(FrameView::create(frame.get()));

frame->init();

FrameLoader& loader = frame->loader();