third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp - Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add HeapTest unit test + rebase upto r384858. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceMotionDispatcher.cpp ('k') | third_party/WebKit/Source/modules/gamepad/GamepadDispatcher.cpp » ('j') | third_party/WebKit/Source/wtf/StdLibExtras.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp

index d1b3d5a96d75959561e95883a57145ea2b3af233..6a9da88a93b73f7411340a1896ab44a2f1a36157 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp

@@ -39,11 +39,11 @@ namespace blink {

DeviceOrientationDispatcher& DeviceOrientationDispatcher::instance(bool absolute)

{

if (absolute) {

- DEFINE_STATIC_LOCAL(Persistent<DeviceOrientationDispatcher>, deviceOrientationAbsoluteDispatcher, (new DeviceOrientationDispatcher(absolute)));

- return *deviceOrientationAbsoluteDispatcher;

+ DEFINE_STATIC_LOCAL(DeviceOrientationDispatcher, deviceOrientationAbsoluteDispatcher, (new DeviceOrientationDispatcher(absolute)));

+ return deviceOrientationAbsoluteDispatcher;

}

- DEFINE_STATIC_LOCAL(Persistent<DeviceOrientationDispatcher>, deviceOrientationDispatcher, (new DeviceOrientationDispatcher(absolute)));

- return *deviceOrientationDispatcher;

+ DEFINE_STATIC_LOCAL(DeviceOrientationDispatcher, deviceOrientationDispatcher, (new DeviceOrientationDispatcher(absolute)));

+ return deviceOrientationDispatcher;

}

DeviceOrientationDispatcher::DeviceOrientationDispatcher(bool absolute) : m_absolute(absolute)