third_party/WebKit/Source/core/xml/XPathValue.cpp - Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XPathValue.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add HeapTest unit test + rebase upto r384858. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp » ('j') | third_party/WebKit/Source/wtf/StdLibExtras.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/XPathValue.cpp

diff --git a/third_party/WebKit/Source/core/xml/XPathValue.cpp b/third_party/WebKit/Source/core/xml/XPathValue.cpp

index af8836e15a8f9a33785847b35532e8441f1f53a5..06d27401d9eaef8d76cbc1d620d6c699cfa54808 100644

--- a/third_party/WebKit/Source/core/xml/XPathValue.cpp

+++ b/third_party/WebKit/Source/core/xml/XPathValue.cpp

@@ -53,8 +53,8 @@ const NodeSet& Value::toNodeSet(EvaluationContext* context) const

context->hadTypeConversionError = true;

if (!m_data) {

- DEFINE_STATIC_LOCAL(Persistent<NodeSet>, emptyNodeSet, (NodeSet::create()));

- return *emptyNodeSet;

+ DEFINE_STATIC_LOCAL(NodeSet, emptyNodeSet, (NodeSet::create()));

+ return emptyNodeSet;

}

return m_data->nodeSet();