Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: third_party/WebKit/Source/core/loader/EmptyClients.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address compilation failure Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 27 matching lines...) Expand all
38 #include "public/platform/WebApplicationCacheHost.h" 38 #include "public/platform/WebApplicationCacheHost.h"
39 #include "public/platform/WebMediaPlayer.h" 39 #include "public/platform/WebMediaPlayer.h"
40 #include "public/platform/modules/mediasession/WebMediaSession.h" 40 #include "public/platform/modules/mediasession/WebMediaSession.h"
41 #include "public/platform/modules/serviceworker/WebServiceWorkerProvider.h" 41 #include "public/platform/modules/serviceworker/WebServiceWorkerProvider.h"
42 #include "public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h " 42 #include "public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h "
43 43
44 namespace blink { 44 namespace blink {
45 45
46 void fillWithEmptyClients(Page::PageClients& pageClients) 46 void fillWithEmptyClients(Page::PageClients& pageClients)
47 { 47 {
48 DEFINE_STATIC_LOCAL(Persistent<ChromeClient>, dummyChromeClient, (EmptyChrom eClient::create())); 48 DEFINE_STATIC_LOCAL(ChromeClient, dummyChromeClient, (EmptyChromeClient::cre ate()));
49 pageClients.chromeClient = dummyChromeClient.get(); 49 pageClients.chromeClient = &dummyChromeClient;
50 50
51 DEFINE_STATIC_LOCAL(EmptyContextMenuClient, dummyContextMenuClient, ()); 51 DEFINE_STATIC_LOCAL(EmptyContextMenuClient, dummyContextMenuClient, ());
52 pageClients.contextMenuClient = &dummyContextMenuClient; 52 pageClients.contextMenuClient = &dummyContextMenuClient;
53 53
54 DEFINE_STATIC_LOCAL(EmptyDragClient, dummyDragClient, ()); 54 DEFINE_STATIC_LOCAL(EmptyDragClient, dummyDragClient, ());
55 pageClients.dragClient = &dummyDragClient; 55 pageClients.dragClient = &dummyDragClient;
56 56
57 DEFINE_STATIC_LOCAL(EmptyEditorClient, dummyEditorClient, ()); 57 DEFINE_STATIC_LOCAL(EmptyEditorClient, dummyEditorClient, ());
58 pageClients.editorClient = &dummyEditorClient; 58 pageClients.editorClient = &dummyEditorClient;
59 59
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 { 179 {
180 return nullptr; 180 return nullptr;
181 } 181 }
182 182
183 PassOwnPtr<WebApplicationCacheHost> EmptyFrameLoaderClient::createApplicationCac heHost(WebApplicationCacheHostClient*) 183 PassOwnPtr<WebApplicationCacheHost> EmptyFrameLoaderClient::createApplicationCac heHost(WebApplicationCacheHostClient*)
184 { 184 {
185 return nullptr; 185 return nullptr;
186 } 186 }
187 187
188 } // namespace blink 188 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698