Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address compilation failure Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, 2011 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2010, 2011 Nokia Corporation and/or its subsidiary(-ies)
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 { 66 {
67 HTMLContentSelectFilter::trace(visitor); 67 HTMLContentSelectFilter::trace(visitor);
68 } 68 }
69 69
70 private: 70 private:
71 FirstSummarySelectFilter() { } 71 FirstSummarySelectFilter() { }
72 }; 72 };
73 73
74 static DetailsEventSender& detailsToggleEventSender() 74 static DetailsEventSender& detailsToggleEventSender()
75 { 75 {
76 DEFINE_STATIC_LOCAL(Persistent<DetailsEventSender>, sharedToggleEventSender, (DetailsEventSender::create(EventTypeNames::toggle))); 76 DEFINE_STATIC_LOCAL(DetailsEventSender, sharedToggleEventSender, (DetailsEve ntSender::create(EventTypeNames::toggle)));
77 return *sharedToggleEventSender; 77 return sharedToggleEventSender;
78 } 78 }
79 79
80 RawPtr<HTMLDetailsElement> HTMLDetailsElement::create(Document& document) 80 RawPtr<HTMLDetailsElement> HTMLDetailsElement::create(Document& document)
81 { 81 {
82 RawPtr<HTMLDetailsElement> details = new HTMLDetailsElement(document); 82 RawPtr<HTMLDetailsElement> details = new HTMLDetailsElement(document);
83 details->ensureUserAgentShadowRoot(); 83 details->ensureUserAgentShadowRoot();
84 return details.release(); 84 return details.release();
85 } 85 }
86 86
87 HTMLDetailsElement::HTMLDetailsElement(Document& document) 87 HTMLDetailsElement::HTMLDetailsElement(Document& document)
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 { 174 {
175 setAttribute(openAttr, m_isOpen ? nullAtom : emptyAtom); 175 setAttribute(openAttr, m_isOpen ? nullAtom : emptyAtom);
176 } 176 }
177 177
178 bool HTMLDetailsElement::isInteractiveContent() const 178 bool HTMLDetailsElement::isInteractiveContent() const
179 { 179 {
180 return true; 180 return true;
181 } 181 }
182 182
183 } // namespace blink 183 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698