Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address compilation failure Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 24 matching lines...) Expand all
35 35
36 namespace blink { 36 namespace blink {
37 37
38 size_t CustomElementProcessingStack::s_elementQueueStart = 0; 38 size_t CustomElementProcessingStack::s_elementQueueStart = 0;
39 39
40 // The base of the stack has a null sentinel value. 40 // The base of the stack has a null sentinel value.
41 size_t CustomElementProcessingStack::s_elementQueueEnd = kNumSentinels; 41 size_t CustomElementProcessingStack::s_elementQueueEnd = kNumSentinels;
42 42
43 CustomElementProcessingStack& CustomElementProcessingStack::instance() 43 CustomElementProcessingStack& CustomElementProcessingStack::instance()
44 { 44 {
45 DEFINE_STATIC_LOCAL(Persistent<CustomElementProcessingStack>, instance, (new CustomElementProcessingStack())); 45 DEFINE_STATIC_LOCAL(CustomElementProcessingStack, instance, (new CustomEleme ntProcessingStack));
46 return *instance; 46 return instance;
47 } 47 }
48 48
49 // Dispatches callbacks when popping the processing stack. 49 // Dispatches callbacks when popping the processing stack.
50 void CustomElementProcessingStack::processElementQueueAndPop() 50 void CustomElementProcessingStack::processElementQueueAndPop()
51 { 51 {
52 instance().processElementQueueAndPop(s_elementQueueStart, s_elementQueueEnd) ; 52 instance().processElementQueueAndPop(s_elementQueueStart, s_elementQueueEnd) ;
53 } 53 }
54 54
55 void CustomElementProcessingStack::processElementQueueAndPop(size_t start, size_ t end) 55 void CustomElementProcessingStack::processElementQueueAndPop(size_t start, size_ t end)
56 { 56 {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 m_flattenedProcessingStack.append(callbackQueue); 89 m_flattenedProcessingStack.append(callbackQueue);
90 ++s_elementQueueEnd; 90 ++s_elementQueueEnd;
91 } 91 }
92 92
93 DEFINE_TRACE(CustomElementProcessingStack) 93 DEFINE_TRACE(CustomElementProcessingStack)
94 { 94 {
95 visitor->trace(m_flattenedProcessingStack); 95 visitor->trace(m_flattenedProcessingStack);
96 } 96 }
97 97
98 } // namespace blink 98 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698