Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementObserver.cpp

Issue 1850413002: Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address compilation failure Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 22 matching lines...) Expand all
33 #include "core/dom/Element.h" 33 #include "core/dom/Element.h"
34 34
35 namespace blink { 35 namespace blink {
36 36
37 // Maps elements to the observer watching them. At most one per 37 // Maps elements to the observer watching them. At most one per
38 // element at a time. 38 // element at a time.
39 typedef HeapHashMap<WeakMember<Element>, Member<CustomElementObserver>> ElementO bserverMap; 39 typedef HeapHashMap<WeakMember<Element>, Member<CustomElementObserver>> ElementO bserverMap;
40 40
41 static ElementObserverMap& elementObservers() 41 static ElementObserverMap& elementObservers()
42 { 42 {
43 DEFINE_STATIC_LOCAL(Persistent<ElementObserverMap>, map, (new ElementObserve rMap())); 43 DEFINE_STATIC_LOCAL(ElementObserverMap, map, (new ElementObserverMap));
44 return *map; 44 return map;
45 } 45 }
46 46
47 void CustomElementObserver::notifyElementWasDestroyed(Element* element) 47 void CustomElementObserver::notifyElementWasDestroyed(Element* element)
48 { 48 {
49 ElementObserverMap::iterator it = elementObservers().find(element); 49 ElementObserverMap::iterator it = elementObservers().find(element);
50 if (it == elementObservers().end()) 50 if (it == elementObservers().end())
51 return; 51 return;
52 it->value->elementWasDestroyed(element); 52 it->value->elementWasDestroyed(element);
53 } 53 }
54 54
55 void CustomElementObserver::observe(Element* element) 55 void CustomElementObserver::observe(Element* element)
56 { 56 {
57 ElementObserverMap::AddResult result = elementObservers().add(element, this) ; 57 ElementObserverMap::AddResult result = elementObservers().add(element, this) ;
58 ASSERT_UNUSED(result, result.isNewEntry); 58 ASSERT_UNUSED(result, result.isNewEntry);
59 } 59 }
60 60
61 void CustomElementObserver::unobserve(Element* element) 61 void CustomElementObserver::unobserve(Element* element)
62 { 62 {
63 CustomElementObserver* observer = elementObservers().take(element); 63 CustomElementObserver* observer = elementObservers().take(element);
64 ASSERT_UNUSED(observer, observer == this); 64 ASSERT_UNUSED(observer, observer == this);
65 } 65 }
66 66
67 } // namespace blink 67 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698