Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1850313002: Fix Fullscreen Animation Crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 7eec24016ad9f688415a3dc6ada8a55fd97fe9f0..5af6f47d49676b64f1ea624a50a86f1481bf6995 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -458,6 +458,13 @@ void SetUpBrowserWindowCommandHandler(NSWindow* window) {
[presentationModeController_ exitPresentationMode];
presentationModeController_.reset();
+ // Explicitly release |fullscreenTransition_| here since it may call back to
+ // this BWC in |-dealloc|. Reset the fullscreen variables.
+ if (fullscreenTransition_) {
+ [fullscreenTransition_ browserWillBeDestroyed];
+ [self resetCustomAppKitFullscreenVariables];
+ }
+
// Under certain testing configurations we may not actually own the browser.
if (ownsBrowser_ == NO)
ignore_result(browser_.release());
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698