chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm - Issue 1850313002: Fix Fullscreen Animation Crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm

Issue 1850313002: Fix Fullscreen Animation Crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm b/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm

index 1a0792aa5cf9039d0eb00a55237b2e63a9298653..c1ddc6a7ae21c3a4c24da3895440d0ebd56c5230 100644

--- a/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm

+++ b/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm

@@ -524,11 +524,11 @@ class FrameAndStyleLock {

[root removeAnimationForKey:kPrimaryWindowAnimationID];

root.opacity = 1;

+ completedTransition_ = YES;

if (!isEnteringFullscreen_)

[controller_ exitFullscreenAnimationFinished];

}

- completedTransition_ = YES;

}

- (CALayer*)rootLayerOfWindow:(NSWindow*)window {