Fix SkTFits in to work properly with signed/unsigned mixtures.

tests/FitsInTest.cpp

Index: tests/FitsInTest.cpp
===================================================================
--- tests/FitsInTest.cpp	(revision 0)
+++ tests/FitsInTest.cpp	(working copy)
@@ -0,0 +1,71 @@
+/*
+ * Copyright 2013 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "Test.h"
+#include "SkTFitsIn.h"
+#include <limits.h>
+namespace {
+
+#define TEST(S, s, D, expected) REPORTER_ASSERT(reporter, (SkTFitsIn<D>((S)(s)) == (expected)));
+
+static void FitsInTest(skiatest::Reporter* reporter) {
+    TEST(int, 1, signed char, true);
+    TEST(int, -1, signed char, true);
+    TEST(int, (int)SCHAR_MAX, signed char, true);
+    TEST(int, (int)SCHAR_MAX+1, signed char, false);
+    TEST(int, (int)SCHAR_MIN, signed char, true);
+    TEST(int, (int)SCHAR_MIN-1, signed char, false);
+
+    TEST(int, 1, unsigned char, true);
+    TEST(int, -1, unsigned char, false);
+    TEST(int, (int)UCHAR_MAX, unsigned char, true);
+    TEST(int, (int)UCHAR_MAX+1, unsigned char, false);
+    TEST(int, 0, unsigned char, true);
+    TEST(int, -1, unsigned char, false);
+    TEST(int, -127, unsigned char, false);
+    TEST(int, -128, unsigned char, false);
+
+    TEST(int, 1000, signed char, false);
+    TEST(int, 1000, unsigned char, false);
+
+    TEST(int, 1, int, true);
+    TEST(int, -1, int, true);
+    TEST(int, 1, unsigned int, true);
+    TEST(int, -1, unsigned int, false);
+
+    TEST(int, 1, long, true);
+    TEST(int, -1, long, true);
+    TEST(int, 1, unsigned long, true);
+    TEST(int, -1, unsigned long, false);
+
+    TEST(unsigned int, 1, signed char, true);
+    TEST(unsigned int, 1, unsigned char, true);
+    TEST(unsigned int, 1, int, true);
+    TEST(unsigned int, 1, unsigned int, true);
+    TEST(unsigned int, 1, long, true);
+    TEST(unsigned int, 1, unsigned long, true);
+
+    TEST(unsigned int, UINT_MAX, signed char, false);
+    TEST(unsigned int, UINT_MAX, unsigned char, false);
+    TEST(unsigned int, UINT_MAX, int, false);
+    TEST(unsigned int, UINT_MAX, unsigned int, true);
+    TEST(unsigned int, UINT_MAX, long, true);
+    TEST(unsigned int, UINT_MAX, unsigned long, true)
+
+    TEST(unsigned long, 1, signed char, true);
+    TEST(unsigned long, 1, unsigned char, true);
+    TEST(unsigned long, 1, int, true);
+    TEST(unsigned long, 1, unsigned int, true);
+    TEST(unsigned long, 1, long, true);
+    TEST(unsigned long, 1, unsigned long, true);
+}
+
+}
+
+#include "TestClassDef.h"
+DEFINE_TESTCLASS("FitsIn", FitsInTestClass, FitsInTest)
+