Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 18503006: Move representation into HObjectAccess and remove from HLoadNamedField and HStoreNamedField. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | src/hydrogen.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 } 430 }
431 431
432 432
433 Handle<Code> KeyedLoadFastElementStub::GenerateCode() { 433 Handle<Code> KeyedLoadFastElementStub::GenerateCode() {
434 return DoGenerateCode(this); 434 return DoGenerateCode(this);
435 } 435 }
436 436
437 437
438 template<> 438 template<>
439 HValue* CodeStubGraphBuilder<LoadFieldStub>::BuildCodeStub() { 439 HValue* CodeStubGraphBuilder<LoadFieldStub>::BuildCodeStub() {
440 Representation rep = casted_stub()->representation();
440 HObjectAccess access = casted_stub()->is_inobject() ? 441 HObjectAccess access = casted_stub()->is_inobject() ?
441 HObjectAccess::ForJSObjectOffset(casted_stub()->offset()) : 442 HObjectAccess::ForJSObjectOffset(casted_stub()->offset(), rep) :
442 HObjectAccess::ForBackingStoreOffset(casted_stub()->offset()); 443 HObjectAccess::ForBackingStoreOffset(casted_stub()->offset(), rep);
443 return AddInstruction(BuildLoadNamedField(GetParameter(0), access, 444 return AddInstruction(BuildLoadNamedField(GetParameter(0), access));
444 casted_stub()->representation()));
445 } 445 }
446 446
447 447
448 Handle<Code> LoadFieldStub::GenerateCode() { 448 Handle<Code> LoadFieldStub::GenerateCode() {
449 return DoGenerateCode(this); 449 return DoGenerateCode(this);
450 } 450 }
451 451
452 452
453 template<> 453 template<>
454 HValue* CodeStubGraphBuilder<KeyedLoadFieldStub>::BuildCodeStub() { 454 HValue* CodeStubGraphBuilder<KeyedLoadFieldStub>::BuildCodeStub() {
455 Representation rep = casted_stub()->representation();
455 HObjectAccess access = casted_stub()->is_inobject() ? 456 HObjectAccess access = casted_stub()->is_inobject() ?
456 HObjectAccess::ForJSObjectOffset(casted_stub()->offset()) : 457 HObjectAccess::ForJSObjectOffset(casted_stub()->offset(), rep) :
457 HObjectAccess::ForBackingStoreOffset(casted_stub()->offset()); 458 HObjectAccess::ForBackingStoreOffset(casted_stub()->offset(), rep);
458 return AddInstruction(BuildLoadNamedField(GetParameter(0), access, 459 return AddInstruction(BuildLoadNamedField(GetParameter(0), access));
459 casted_stub()->representation()));
460 } 460 }
461 461
462 462
463 Handle<Code> KeyedLoadFieldStub::GenerateCode() { 463 Handle<Code> KeyedLoadFieldStub::GenerateCode() {
464 return DoGenerateCode(this); 464 return DoGenerateCode(this);
465 } 465 }
466 466
467 467
468 template <> 468 template <>
469 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() { 469 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() {
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 return graph()->GetConstant0(); 776 return graph()->GetConstant0();
777 } 777 }
778 778
779 779
780 Handle<Code> ToBooleanStub::GenerateCode() { 780 Handle<Code> ToBooleanStub::GenerateCode() {
781 return DoGenerateCode(this); 781 return DoGenerateCode(this);
782 } 782 }
783 783
784 784
785 } } // namespace v8::internal 785 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698