Combined test runner.

Combined test runner.

This CL revives the old CL to combine the test runners [1] which was reverted
due to failing font_size tests. I've deleted the font_size.pdf as it is not
needed and for testing. Pixel tests are either .in or .pdf files, not both.

Original description:
This CL takes the three test runners (corpus, javascript, pixel) and combines
the code into a single test_runner file. Each of the individual runners still
exists and calls the test runner with their data directory.

With this change, the pixel and javascript test will now run in parallel if
multiple processors are available.

1-https://codereview.chromium.org/1430623006/

Committed: https://pdfium.googlesource.com/pdfium/+/03e8f12cd3788038225d0376a164a9993f6cb720

[dsinclair, 2016-04-01 23:50:44]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-01 23:50:45]

PTAL.

[dsinclair, 2016-04-05 13:15:06]

ping.

[Tom Sepez, 2016-04-05 16:39:53]

I'd like to defer to Lei, whose python-fu is better than mine.

[Lei Zhang, 2016-04-05 23:33:24]

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.py
File testing/tools/test_runner.py (right):

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.p...
testing/tools/test_runner.py:95: if os.path.exists(original_path) and not
os.path.exists(input_path):
Can we combine this with line 98?

if not os.path.exists(input_path):
  if os.path.exists(original_path):
    shutil.copyfile(original_path, pdf_path)
  return None

# Add Dr. Memory wrapper...

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.p...
testing/tools/test_runner.py:103: os.path.splitext(input_root))
- Funny indentation.
- Do you need to call splitext() when |input_root| should already have no
extension? Also update comment on line 101.

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.p...
testing/tools/test_runner.py:105: '--output-dir=' + self.working_dir,
input_path])
Funny indentation.

[dsinclair, 2016-04-06 13:39:33]

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.py
File testing/tools/test_runner.py (right):

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.p...
testing/tools/test_runner.py:95: if os.path.exists(original_path) and not
os.path.exists(input_path):
On 2016/04/05 23:33:24, Lei Zhang wrote:
> Can we combine this with line 98?
> 
> if not os.path.exists(input_path):
>   if os.path.exists(original_path):
>     shutil.copyfile(original_path, pdf_path)
>   return None
> 
> # Add Dr. Memory wrapper...

Done.

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.p...
testing/tools/test_runner.py:103: os.path.splitext(input_root))
On 2016/04/05 23:33:24, Lei Zhang wrote:
> - Funny indentation.
> - Do you need to call splitext() when |input_root| should already have no
> extension? Also update comment on line 101.

Done.

https://codereview.chromium.org/1850273003/diff/1/testing/tools/test_runner.p...
testing/tools/test_runner.py:105: '--output-dir=' + self.working_dir,
input_path])
On 2016/04/05 23:33:24, Lei Zhang wrote:
> Funny indentation.

Done.

[Lei Zhang, 2016-04-06 19:14:28]

lgtm

[dsinclair, 2016-04-06 19:15:03]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-06 19:15:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850273003/20001

[commit-bot: I haz the power, 2016-04-06 19:15:29]

Description was changed from

==========
Combined test runner.

This CL revives the old CL to combine the test runners [1] which was reverted
due to failing font_size tests. I've deleted the font_size.pdf as it is not
needed and for testing. Pixel tests are either .in or .pdf files, not both.

Original description:
This CL takes the three test runners (corpus, javascript, pixel) and combines
the code into a single test_runner file. Each of the individual runners still
exists and calls the test runner with their data directory.

With this change, the pixel and javascript test will now run in parallel if
multiple processors are available.

1-https://codereview.chromium.org/1430623006/
==========

to

==========
Combined test runner.

This CL revives the old CL to combine the test runners [1] which was reverted
due to failing font_size tests. I've deleted the font_size.pdf as it is not
needed and for testing. Pixel tests are either .in or .pdf files, not both.

Original description:
This CL takes the three test runners (corpus, javascript, pixel) and combines
the code into a single test_runner file. Each of the individual runners still
exists and calls the test runner with their data directory.

With this change, the pixel and javascript test will now run in parallel if
multiple processors are available.

1-https://codereview.chromium.org/1430623006/

Committed:
https://pdfium.googlesource.com/pdfium/+/03e8f12cd3788038225d0376a164a9993f6c...
==========

[commit-bot: I haz the power, 2016-04-06 19:15:30]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/03e8f12cd3788038225d0376a164a9993f6c...

[dsinclair, 2016-04-06 21:04:31]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1867643002/ by dsinclair@chromium.org.

The reason for reverting is: Broke Dr. Memory.