Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Issue 1850253002: Revert of [Sync] Eliminate verifier profile from sync_integration_tests (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
Reviewers:
Nicolas Zea, shadi
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Eliminate verifier profile from sync_integration_tests (patchset #3 id:60001 of https://codereview.chromium.org/1834323004/ ) Reason for revert: This CL has resulted in test flakiness - please see https://crbug.com/599787 Original issue's description: > [Sync] Eliminate verifier profile from sync_integration_tests > > This is one of a series of changes to get rid of verifier profile in two client > sync integration tests. > > This CL affects apps and app_list two client tests only. > > BUG=598802 > > Committed: https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4 > Cr-Commit-Position: refs/heads/master@{#384462} TBR=zea@chromium.org,shadi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598802 Committed: https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28 Cr-Commit-Position: refs/heads/master@{#384634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -323 lines) Patch
M chrome/browser/sync/test/integration/apps_helper.h View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/sync/test/integration/apps_helper.cc View 4 chunks +13 lines, -25 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 6 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/sync/test/integration/extensions_helper.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_apps_sync_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_app_list_helper.h View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_app_list_helper.cc View 3 chunks +52 lines, -31 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 21 chunks +213 lines, -151 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 18 chunks +41 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 14 chunks +47 lines, -47 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Łukasz Anforowicz
Created Revert of [Sync] Eliminate verifier profile from sync_integration_tests
4 years, 8 months ago (2016-04-01 18:20:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850253002/1
4 years, 8 months ago (2016-04-01 18:21:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 18:21:57 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:23:12 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28
Cr-Commit-Position: refs/heads/master@{#384634}

Powered by Google App Engine
This is Rietveld 408576698