Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1850223002: Remove "#pragma comment(lib" in media. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "#pragma comment(lib" in media. BUG=597028 Committed: https://crrev.com/e266135aab534260b8f4a2eb956d1f71ab106ae8 Cr-Commit-Position: refs/heads/master@{#384928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M media/audio/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/win/wavein_input_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/win/waveout_output_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jam
4 years, 8 months ago (2016-04-01 16:04:03 UTC) #2
xhwang
xhwang -> dalecurtis since he's more familiar with audio code
4 years, 8 months ago (2016-04-01 16:07:08 UTC) #4
DaleCurtis
lgtm for media.gyp, but +tommi for media/audio
4 years, 8 months ago (2016-04-01 17:27:33 UTC) #7
tommi (sloooow) - chröme
Lgtm. Maybe we can start removing the wave code?
4 years, 8 months ago (2016-04-02 11:50:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850223002/1
4 years, 8 months ago (2016-04-04 15:21:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 16:49:03 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e266135aab534260b8f4a2eb956d1f71ab106ae8 Cr-Commit-Position: refs/heads/master@{#384928}
4 years, 8 months ago (2016-04-04 16:51:32 UTC) #13
Łukasz Anforowicz
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1855183005/ by lukasza@chromium.org. ...
4 years, 8 months ago (2016-04-04 17:24:35 UTC) #14
DaleCurtis
4 years, 8 months ago (2016-04-04 18:16:39 UTC) #15
Message was sent while issue was closed.
I think we still fallback to wave on some WASAPI platforms, so we'd have to
check the UMA and add some tracking to see that if WASAPI fails WaveOut will
fail too.

Powered by Google App Engine
This is Rietveld 408576698